Skip to content

Commit 0b37082

Browse files
thingalonMark George
and
Mark George
authored
[Boost] Fix styles around CSS and JS concatenate options (#35150)
* Fix JS and CSS minify styles * Cleanup * changelog * version bump boost, as required by monorepo tooling --------- Co-authored-by: Mark George <[email protected]>
1 parent b8e9e8b commit 0b37082

File tree

8 files changed

+26
-9
lines changed

8 files changed

+26
-9
lines changed

projects/plugins/boost/app/assets/src/js/features/minify-meta/minify-meta.module.scss

+12
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11
@import "../../../css/main/variables.scss";
22

3+
.minify-meta {
4+
align-items: flex-start;
5+
display: flex;
6+
flex-direction: row;
7+
font-size: 14px;
8+
line-height: 22px;
9+
}
10+
11+
.summary {
12+
flex-grow: 1;
13+
}
14+
315
.manage-excludes {
416
display: flex;
517
flex-direction: column;

projects/plugins/boost/app/assets/src/js/features/minify-meta/minify-meta.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const MetaComponent = ( { inputLabel, buttonText, placeholder, datasyncKey }: Pr
2121
const htmlId = `jb-minify-meta-${ datasyncKey }`;
2222

2323
return (
24-
<div className="jb-critical-css__meta">
24+
<div className={ styles[ 'minify-meta' ] }>
2525
{ isEditing ? (
2626
<div className={ styles[ 'manage-excludes' ] }>
2727
<label htmlFor={ htmlId }>{ inputLabel }</label>
@@ -43,7 +43,7 @@ const MetaComponent = ( { inputLabel, buttonText, placeholder, datasyncKey }: Pr
4343
</div>
4444
) : (
4545
<>
46-
<div className="summary">
46+
<div className={ styles.summary }>
4747
{ values.length > 0 && (
4848
<div className="successes">
4949
{ sprintf(

projects/plugins/boost/app/assets/src/js/lib/stores/minify.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ export const useMetaQuery = ( key: MinifyMetaKeys ) => {
1919
mutate( text.split( ',' ).map( item => item.trim() ) );
2020
}
2121

22-
return [ data, updateValues ] as const;
22+
return [ data || [], updateValues ] as const;
2323
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Significance: patch
2+
Type: fixed
3+
Comment: Fixed broken styling around css and js minify
4+
5+

projects/plugins/boost/composer.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "Boost your WordPress site's performance, from the creators of Jetpack",
44
"type": "library",
55
"license": "GPL-2.0-or-later",
6-
"version": "3.0.0-beta",
6+
"version": "3.0.1-alpha",
77
"authors": [
88
{
99
"name": "Automattic, Inc.",
@@ -73,7 +73,7 @@
7373
"platform": {
7474
"ext-intl": "0.0.0"
7575
},
76-
"autoloader-suffix": "b1e77e6231d50e7663f84529b6a3dfda_jetpack_boostⓥ3_0_0_beta",
76+
"autoloader-suffix": "b1e77e6231d50e7663f84529b6a3dfda_jetpack_boostⓥ3_0_1_alpha",
7777
"allow-plugins": {
7878
"roots/wordpress-core-installer": true,
7979
"automattic/jetpack-autoloader": true,

projects/plugins/boost/composer.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projects/plugins/boost/jetpack-boost.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* Plugin Name: Jetpack Boost
1010
* Plugin URI: https://jetpack.com/boost
1111
* Description: Boost your WordPress site's performance, from the creators of Jetpack
12-
* Version: 3.0.0-beta
12+
* Version: 3.0.1-alpha
1313
* Author: Automattic - Jetpack Site Speed team
1414
* Author URI: https://jetpack.com/boost/
1515
* License: GPL-2.0+
@@ -29,7 +29,7 @@
2929
die;
3030
}
3131

32-
define( 'JETPACK_BOOST_VERSION', '3.0.0-beta' );
32+
define( 'JETPACK_BOOST_VERSION', '3.0.1-alpha' );
3333
define( 'JETPACK_BOOST_SLUG', 'jetpack-boost' );
3434

3535
if ( ! defined( 'JETPACK_BOOST_CLIENT_NAME' ) ) {

projects/plugins/boost/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jetpack-boost",
3-
"version": "3.0.0-beta",
3+
"version": "3.0.1-alpha",
44
"description": "Boost your WordPress site's performance, from the creators of Jetpack",
55
"directories": {
66
"test": "tests"

0 commit comments

Comments
 (0)