SEO: Keep the menu item when SEO tools is off (#53940)

* SEO: keep the sidebar menu item visible when seo-tools module is off

Dropping 'module' => 'seo-tools' from Admin_Page::add_menu_item()'s args
stops the visibility resolver from hiding the item when the module is
inactive. The key 'jetpack-seo' is kept so hosts can still control it via
the jetpack_admin_menu_visibility filter.

Co-authored-by: matticbot <matticbot@users.noreply.github.com>

* SEO: Make the menu fix changelog entry comment-only

The new SEO page is still behind its rollout gate.

---------

Co-authored-by: haqadn <adnan.haque@automattic.com>
Co-authored-by: matticbot <matticbot@users.noreply.github.com>
Co-authored-by: Adnan Haque <adnan007.id@gmail.com>

Author: 3 people

projects/packages/seo/changelog/ai-agent-jetpack-3113-1792599448

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+Comment: Keep the SEO menu item in the sidebar when the seo-tools module is off. The new SEO page is gated.
+

projects/packages/seo/src/class-admin-page.php

@@ -84,10 +84,11 @@ public static function add_menu_item() {
 			self::MENU_SLUG,
 			$callback,
 			null,
-			// SEO has no My Jetpack product class, so the module is the only gate available.
+			// No module gate: the menu must stay visible even when seo-tools is off so the
+			// user can turn it back on from the page. Hosts may still use the
+			// jetpack_admin_menu_visibility filter to hide it via the 'jetpack-seo' key.
 			array(
-				'module' => 'seo-tools',
-				'key'    => 'jetpack-seo',
+				'key' => 'jetpack-seo',
 			)
 		);
 

projects/packages/seo/tests/php/AdminPageTest.php

@@ -212,6 +212,32 @@ public function test_alias_screen_id_round_trip() {
 		$this->assertSame( 'jetpack_page_jetpack-seo', get_current_screen()->id );
 	}
 
+	/**
+	 * The menu must be visible even when seo-tools is off, so the user can turn it back on.
+	 * Verified by checking that no module gate is declared on the registered item.
+	 */
+	public function test_menu_item_is_registered_without_a_module_gate() {
+		Admin_Page::add_menu_item();
+
+		$menu_items = new \ReflectionProperty( Admin_Menu::class, 'menu_items' );
+		if ( \PHP_VERSION_ID < 80100 ) {
+			$menu_items->setAccessible( true );
+		}
+		$items = $menu_items->getValue( null );
+
+		$seo_item = null;
+		foreach ( $items as $item ) {
+			if ( Admin_Page::MENU_SLUG === $item['menu_slug'] ) {
+				$seo_item = $item;
+				break;
+			}
+		}
+
+		$this->assertNotNull( $seo_item, 'SEO menu item was not registered' );
+		$this->assertArrayNotHasKey( 'module', $seo_item['args'] ?? array() );
+		$this->assertSame( 'jetpack-seo', $seo_item['args']['key'] ?? null );
+	}
+
 	/**
 	 * The dashboard opts the screen Admin_Menu registers out of JITMs, and no other.
 	 */