Added integers 1 and 0 to is_truthy and is_falsy. (#35190)

* Added 0 and 1 as integers to is_truthy and is_falsy.

* Changelog.

* Update projects/plugins/jetpack/class.json-api.php

Co-authored-by: Brad Jorsch <[email protected]>

* Update projects/plugins/jetpack/class.json-api.php

Co-authored-by: Brad Jorsch <[email protected]>

* Singling out allowed values instead of is_int check.

---------

Co-authored-by: Brad Jorsch <[email protected]>

Author: zinigor

projects/plugins/jetpack/changelog/add-integers-to-is-truthy

@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+REST API: fixed the way we treat 0 and 1 integers in boolean context.

projects/plugins/jetpack/class.json-api.php

@@ -205,14 +205,18 @@ public function add( WPCOM_JSON_API_Endpoint $endpoint ) {
 	 * Determine if a string is truthy. If it's not a string, which can happen with
 	 * not well-formed data coming from Jetpack sites, we still consider it a truthy value.
 	 *
-	 * @param string $value "1", "t", and "true" (case insensitive) are truthy, everything else isn't.
+	 * @param mixed $value true, 1, "1", "t", and "true" (case insensitive) are truthy, everything else isn't.
 	 * @return bool
 	 */
 	public static function is_truthy( $value ) {
 		if ( true === $value ) {
 			return true;
 		}
 
+		if ( 1 === $value ) {
+			return true;
+		}
+
 		if ( ! is_string( $value ) ) {
 			return false;
 		}
@@ -230,14 +234,18 @@ public static function is_truthy( $value ) {
 	/**
 	 * Determine if a string is falsey.
 	 *
-	 * @param string $value "0", "f", and "false" (case insensitive) are falsey, everything else isn't.
+	 * @param mixed $value false, 0, "0", "f", and "false" (case insensitive) are falsey, everything else isn't.
 	 * @return bool
 	 */
 	public static function is_falsy( $value ) {
 		if ( false === $value ) {
 			return true;
 		}
 
+		if ( 0 === $value ) {
+			return true;
+		}
+
 		if ( ! is_string( $value ) ) {
 			return false;
 		}