Jetpack: Don't run tsc in production builds, do it in tests instead (#35582)

Production builds are mostly run in CI, while developers will normally
be doing non-production builds.

We can speed up the CI Build job somewhat by not running `tsc` there,
since in our current setup it doesn't actually build anything (it just
checks types). The type checking can instead be done by the Tests / JS
tests job.

Author: anomiex

projects/plugins/jetpack/changelog/add-jetpack-tsc-in-tests-not-build

@@ -0,0 +1,5 @@
+Significance: patch
+Type: other
+Comment: Don't run `tsc` for production builds, run it in CI tests instead.
+
+

projects/plugins/jetpack/composer.json

@@ -69,7 +69,7 @@
 			"tests/action-phpunit.sh"
 		],
 		"test-js": [
-			"pnpm concurrently 'pnpm:test-adminpage' 'pnpm:test-extensions'"
+			"pnpm concurrently 'pnpm:compile-ts' 'pnpm:test-adminpage' 'pnpm:test-extensions'"
 		],
 		"test-php": [
 			"@php tools/build-module-headings-translations.php",

projects/plugins/jetpack/package.json

@@ -21,7 +21,7 @@
 		"build-concurrently": "pnpm run clean && concurrently 'pnpm:compile-ts' 'pnpm:build-client' 'pnpm:build-extensions' 'pnpm:build-widget-visibility' && pnpm run build-asset-cdn-json",
 		"build-extensions": "webpack --config ./tools/webpack.config.extensions.js && tools/check-block-assets.php",
 		"build-production": "pnpm run clean && pnpm run build-production-client && pnpm run build-production-extensions && pnpm run build-production-widget-visibility && pnpm run build-asset-cdn-json",
-		"build-production-concurrently": "pnpm run clean && concurrently 'pnpm:compile-ts' 'pnpm:build-production-client' 'pnpm:build-production-extensions' 'pnpm:build-production-widget-visibility' && pnpm run build-asset-cdn-json",
+		"build-production-concurrently": "pnpm run clean && concurrently 'pnpm:compile-ts-production' 'pnpm:build-production-client' 'pnpm:build-production-extensions' 'pnpm:build-production-widget-visibility' && pnpm run build-asset-cdn-json",
 		"build-production-client": "NODE_ENV=production BABEL_ENV=production pnpm run build-client && pnpm exec validate-es ./_inc/build/",
 		"build-production-extensions": "NODE_ENV=production BABEL_ENV=production pnpm run build-extensions && pnpm exec validate-es ./_inc/blocks",
 		"build-production-widget-visibility": "NODE_ENV=production BABEL_ENV=production pnpm run build-widget-visibility && pnpm exec validate-es ./_inc/build/widget-visibility/editor",
@@ -30,6 +30,7 @@
 		"clean-client": "rm -rf _inc/build/ css/",
 		"clean-extensions": "rm -rf _inc/blocks/ ",
 		"compile-ts": "tsc --pretty",
+		"compile-ts-production": "# For production builds, we run tsc in the CI 'Tests / JS tests' job instead of in the build.",
 		"fixtures:regenerate": "REGENERATE_FIXTURES=y GENERATE_MISSING_FIXTURES=y pnpm test-extensions",
 		"fixtures:generate": "GENERATE_MISSING_FIXTURES=y pnpm test-extensions",
 		"fixtures:test": "pnpm test-extensions validate.js",