Forms: Hide empty radio fields (#41379)

Author: edanzer

projects/packages/forms/changelog/fix-form-radio-with-no-options

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Forms: Hide empty radio fields.

projects/packages/forms/src/contact-form/class-contact-form-field.php

@@ -1000,6 +1000,10 @@ class="below-label__label ' . ( $this->is_error() ? ' form-error' : '' ) . '"
 	 * @return string HTML
 	 */
 	public function render_field( $type, $id, $label, $value, $class, $placeholder, $required, $required_field_text ) {
+		if ( ! $this->is_field_renderable( $type ) ) {
+			return null;
+		}
+
 		$class .= ' grunion-field';
 
 		$form_style = $this->get_form_style();
@@ -1141,6 +1145,33 @@ private function maybe_override_type() {
 		return $type;
 	}
 
+	/**
+	 * Determines if a form field is valid.
+	 *
+	 * Add checks here to confirm if any given form field
+	 * is configured correctly and thus should be rendered
+	 * on the frontend.
+	 *
+	 * @param string $type - the field type.
+	 *
+	 * @return bool
+	 */
+	public function is_field_renderable( $type ) {
+		// Check for valid radio field.
+		if ( $type === 'radio' ) {
+			$options           = (array) $this->get_attribute( 'options' );
+			$non_empty_options = array_filter(
+				$options,
+				function ( $option ) {
+					return $option !== '';
+				}
+			);
+			return count( $non_empty_options ) > 0;
+		}
+
+		return true;
+	}
+
 	/**
 	 * Gets the form style based on its CSS class.
 	 *

projects/plugins/jetpack/changelog/fix-form-radio-with-no-options

@@ -0,0 +1,4 @@
+Significance: patch
+Type: bugfix
+
+Forms: Hide empty radio fields.