Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLT proxy for Likes and Notifications #19208

Closed
wants to merge 4 commits into from
Closed

RLT proxy for Likes and Notifications #19208

wants to merge 4 commits into from

Conversation

gravityrail
Copy link
Contributor

Fixes #15184

Changes proposed in this Pull Request:

  • Fix Like buttons in Safari by enabling cross-domain authentication.

Jetpack product discussion

pcNnmV-1L-p2

Does this pull request change what data or activity we track or use?

This provides the browser with a token, known as an RLT or "Remote Login Token", which is used to authorize Like and Notification requests, just like we currently do with cookies. The token is stored in localStorage for the Jetpack site, in the user's browser, and sent with some API requests. The reason for this change is that browsers are increasingly blocking "third-party" cookies - which includes any cookies normally set or sent by cross-origin iframes.

Testing instructions:

  • In Chrome Incognito mode, or in Safari, attempt to interact with a Like or Comment Like button.
  • You should be prompted to log into your WPCOM account in a popup.
  • Upon successful login, the Like or Comment Like button should become interactive.
  • Bonus: if you are logged into the site itself, and have toolbar notifications enabled, then that widget will now work as well - but only if you have Likes enabled.

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Likes labels Mar 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined

Jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 17, 2021
@gravityrail gravityrail added [Status] In Progress and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 18, 2021
@gravityrail gravityrail mentioned this pull request Jul 22, 2021
Closed
@jeherve
Copy link
Member

jeherve commented Mar 2, 2022

I'll close this PR for now because of the lack of activity on this. We can always reopen in the future if needed, but it will need a rebase, so it may be easier to start a new PR at this point.

@jeherve jeherve closed this Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Likes [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Like button: not working by default on in-app browsers on iPhone & Brave browser
3 participants
@gravityrail @jeherve @matticbot