Skip to content

AMP map block doesn't work on non-SSL sites, and throws incorrect errors #16945

Open
@gravityrail

Description

Basically, the issue here is that <amp-iframe/> requires that src= be an https URL.

However, with our current implementation, the map's amp-iframe URL points to the origin (in fact, it only does this for AMP - the native version loads the map in a div and renders on a canvas)

What our implementation should do is render an iframe that points directly to MapBox's iframe rendering endpoint, or even one of our own, that simply takes the marker locations and other configuration info as URL parameters.

Steps to reproduce the issue

  1. On a site without SSL, and with AMP standard mode...
  2. Add a map block
  3. View the page

What I expected

A map

What happened instead

No map - nor even a map-like placeholder. Though it does warn in the editor that http is not a valid protocol for amp-iframe in the editor.

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions