[Deprecate Dashboard] React error and blank page when trying to disconnect (as non-admin)

[jsnajdr]

Impacted plugin

Jetpack

Quick summary

Jetpack UI crashes with React error and a blank page when trying to disconnect a non-admin user

Steps to reproduce

1. Create a self-hosted site, e.g. on Jurassic Ninja, and connect Jetpack
2. Log in as another, non-admin user, and on the my-jetpack page connect that user to your WP.com user account
3. Now click "Disconnect" on that page. My expectation was that I'm going to disconnect the account from WP.com, becoming a purely local user again, and maybe have the chance to connect as another user on WP.com.
   

A clear and concise description of what you expected to happen.

My local account is disconnected from the WP.com one, and I have an opportunity to connect as another WP.com account.

My intent was not to disconnect the entire site, I'm not an Admin or Owner in the first place. Just the one user account.

What actually happened

React crashes and I see blank page:

The React minified error is:

Objects are not valid as a React child (found: [object Error]). If you meant to render a collection of children, use an array instead.

Impact

One

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

No response

[jeherve]

Thanks for the report!

This outlines a more general problem with the My Jetpack page for non-admins in general. Should non-admins even have access to that page? They cannot do much there, I don't know if it's really useful to them.

They also will not be able to access any of the product interstitials since the endpoints are limited to admins:

jetpack/projects/packages/my-jetpack/src/class-rest-products.php

Lines 110 to 112 in d4db4c8

	public static function permissions_callback() {
	return current_user_can( 'manage_options' );
	}

I would be tempted to just limit the pages to admins.

@Automattic/jetpack-agora What's your take on this?

[jsnajdr]

I used this screen to connect my local Jetpack site non-admin account to my WP.com one. If I can no longer access it as non-admin, how do I connect then? Does the admin have some workflow to connect me?

[jeherve]

You should still have access to the standard Jetpack menu:

[jsnajdr]

Thanks! For a non-admin user, however, the behavior of the Jetpack sidebar menu seems a bit off:

• when I click on the top-level "Jetpack" item, I'm navigated to ?page=my-jetpack and the "My Jetpack" item is highlighted:

  

• when I click on the "Dashboard" item, I'm navigated to ?page=jetpack#/dashboard. That's the page in your screenshot, where I can connect and disconnect my non-admin account. But the "Dashboard" menu item is not highlighted, only the top-level "Jetpack" is. Although the "Jetpack" menu item link leads elsewhere.

  

My expectation is that I, as non-admin, don't see "My Jetpack" at all, that "Jetpack" leads to "Dashboard" and that "Dashboard" is highlighted when active.