Bug in action-required-review

[tureck1y]

Impacted plugin

Jetpack

Quick summary

action-required-review will never satisfy requirements if @someuser is an author of a PR and requirements are configured like this:

  teams:
    - all-of:
      - some-team
      - '@someUser'

It's impossible to make a self-review and impossible to merge the PR. An empty team should be excluded from the requirements check. An empty virtual team for @someuser in this case/

Steps to reproduce

1. Configure requirements

- name: Misc
  paths: unmatched
  teams:
    - all-of:
      - some-team
      - '@someUser'

2. Open a PR by @someuser as an author
3. Get approval from any user of "some-team"

Result: Requirement "Misc" is not satisfied by the existing reviews.

Expected result: Requirement "Misc" is satisfied by the existing reviews.

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Major

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform (Simple and/or Atomic)

No response

[github-actions]

OpenAI suggested the following labels for this issue:

• [Feature Group] Content Management: The issue pertains to how content requirements are managed within the Jetpack plugin.
• [Feature] Jetpack CLI: This feature may relate to the command line interface used for managing plugin configurations and settings.
• [Feature] Performance History: The problem ties into performance metrics, as it affects the review and approval process of pull requests.