Skip to content

Commit 07c9896

Browse files
authored
Add workaround for tumblr-metal failing to download Gradle (#1705)
2 parents f169444 + fcd2e08 commit 07c9896

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

fastlane/lanes/localization.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,15 @@
103103
end
104104

105105
desc 'Download the latest app translations from GlotPress and update the strings.xml files accordingly'
106-
lane :download_translations do
106+
lane :download_translations do |run_lint: true|
107107
# android_update_release_notes requires a relative path
108108
res_folder_relative_path = RES_FOLDER.delete_prefix(PROJECT_ROOT_FOLDER)
109109

110110
android_download_translations(
111111
res_dir: res_folder_relative_path,
112112
glotpress_url: GLOTPRESS_APP_STRINGS_PROJECT_URL,
113113
locales: SUPPORTED_LOCALES,
114-
lint_task: 'lintRelease'
114+
lint_task: run_lint ? 'lintRelease' : nil
115115
)
116116
end
117117
end

fastlane/lanes/release.rb

+10-2
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,11 @@
137137
# Print computed version and build to let user double-check outcome in logs
138138
UI.success("Done! New beta version: #{release_version_current}. New build code: #{build_code_current}")
139139

140-
download_translations
140+
download_translations(
141+
# skip lint in CI as a workaround to the task running in an agent that fails to download the Gradle version this project needs.
142+
# The long term fix is to upgrade Gradle here.
143+
run_lint: is_ci == false
144+
)
141145
download_metadata_strings
142146

143147
UI.important('Pushing changes to remote and triggering the beta build...')
@@ -163,7 +167,11 @@
163167
configure_apply(force: is_ci)
164168

165169
check_translation_progress_all unless is_ci
166-
download_translations
170+
download_translations(
171+
# skip lint in CI as a workaround to the task running in an agent that fails to download the Gradle version this project needs.
172+
# The long term fix is to upgrade Gradle here.
173+
run_lint: is_ci == false
174+
)
167175

168176
UI.message 'Bumping final release version and build code...'
169177
VERSION_FILE.write_version(

0 commit comments

Comments
 (0)