-
Notifications
You must be signed in to change notification settings - Fork 29
Pressable Sync: Mark Pressable sites as syncable #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed it, and it works as advertised. I can find and connect my Pressable sites that have a Jetpack connection. Changes LGTM!
List connections | Click connect |
---|---|
![]() |
![]() |
A couple of notes that seem unrelated to this change is that if I close and open Studio again, the pressable sites gets disconnected and I need to Reconnect again:
Close and open Studio |
---|
![]() |
If I try to either Push or Pull, I get an error:
Error with Push and Pull |
---|
![]() |
The issues mentioned are not related to making the Pressable sites as syncables, that is why I think this PR can progress
Thank you for your review, @epeicher.
That's actually a very good catch! I considered fixing this in a separate PR, but it was quite related to the logic introduced in this PR so I applied the change in 840c206 (together with moving the feature flag to the actual API request).
Yes, I agree, we can take a look at it as a part of the Push / Pull tasks we have in Linear. 🙂 |
Once this PR is merged, I am planning to follow up with #1229 where I would like to clean up site sync states. |
Related issues
Proposed Changes
hosting_provider_guess
value from theme/sites/
endpoint (behind thepressableSyncEnabled
feature flag)syncable
Note
The presence of the
Production
badge is a matter of discussion: STU-320-linear-issue#comment-de01edcd. Regardless, we can tackle it in a separate PR.Note
Once this PR is merged, I am planning to follow up with #1229 where I would like to clean up site sync states.
Testing Instructions
STUDIO_PRESSABLE_SYNC=true npm start
.Connect site
button.npm start
only, it shouldn't be possible to connect those same Pressable sites. Everything else should work normally.Pre-merge Checklist