Merge pull request #2059 from Automattic/update/enable-auto-index-setting-updating

Search: Enable auto index setting updating on all sites

Author: nickdaugherty

lib/feature/class-feature.php

@@ -19,7 +19,6 @@ class Feature {
 	public static $feature_percentages = array(
 		// https://github.com/Automattic/vip-go-mu-plugins/tree/master/vip-jetpack/connection-pilot
 		'jetpack-cxn-pilot' => 0.25,
-		'search_indexable_settings_auto_heal' => 0.5,
 		'remove-gutenberg-ramp' => 0.25,
 		'search_content_validation_and_auto_heal_cron_job' => 0.25,
 	);

search/includes/classes/class-healthjob.php

@@ -189,9 +189,7 @@ public function check_all_indexables_settings_health() {
 
 		$this->process_indexables_settings_health_results( $unhealthy_indexables );
 
-		if ( \Automattic\VIP\Feature::is_enabled( 'search_indexable_settings_auto_heal' ) ) {
-			$this->heal_index_settings( $unhealthy_indexables );
-		}
+		$this->heal_index_settings( $unhealthy_indexables );
 	}
 
 	public function process_indexables_settings_health_results( $results ) {
@@ -228,9 +226,7 @@ public function process_indexables_settings_health_results( $results ) {
 					var_export( $result['diff'], true )
 				);
 
-				// Temporarily disable the alerting while we roll out the index settings changes (b/c indexes will be inconsistent during)
-				// Be sure to re-enable the test for this - test__vip_search_healthjob_process_indexables_settings_health_results
-				// $this->send_alert( '#vip-go-es-alerts', $message, 2, "{$indexable_slug}" );
+				$this->send_alert( '#vip-go-es-alerts', $message, 2, "{$indexable_slug}" );
 			}
 		}
 	}

tests/search/includes/classes/test-class-healthjob.php

@@ -58,7 +58,7 @@ public function test__vip_search_healthjob_check_health_with_inactive_features()
 		// Mock the health job
 		$job = $this->getMockBuilder( \Automattic\VIP\Search\HealthJob::class )
 			->setConstructorArgs( [ $es ] )
-			->setMethods( array( 'process_document_count_health_results' ) )
+			->setMethods( array( 'process_document_count_health_results', 'send_alert' ) )
 			->getMock();
 
 		// Only expect it to process 1 set of results (for regular posts)