You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+27-21Lines changed: 27 additions & 21 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -3,45 +3,50 @@
3
3
4
4
:wave: Just a quick reminder that this is a public repo. Please don't include any internal links or sensitive data (like PII, private code, customer names, site URLs, etc. Any fixes related to security should be discussed with Platform before opening a PR. If you're not sure if something is safe to share, please just ask!
5
5
6
-
### BEFORE YOU PROCEED!!
7
-
8
-
If you’re editing a feature without changing the spirit of the implementation, fixing bugs, or performing upgrades, then please proceed!
9
-
10
-
If you’re adding a feature or changing the spirit of an existing implementation, please create a proposal in Cantina P2 using the MU Plugins Proposal Block Pattern. Please mention the [CODEOWNERS](.github/CODEOWNERS) of this repository and relevant stakeholders in your proposal :). Please be aware that any unplanned work may take some time to get reviewed. Thank you 🙇♀️🙇!
11
-
12
6
## For external contributors!
13
7
14
8
Welcome! We look forward to your contribution! ❤️
15
9
-->
16
10
## Description
17
11
<!--
18
-
A few sentences describing the overall goals of the Pull Request.
12
+
A few sentences providing more context and describing the overall goals of the Pull Request.
19
13
20
-
Should include any special considerations, decisions, and links to relevant GitHub issues.
21
-
22
-
Please don't include internal or private links :)
14
+
Should include any special considerations, decisions, and links to relevant publicly available sources (e.g. GitHub issues)
23
15
-->
24
16
25
17
## Changelog Description
26
-
<!--
27
-
A description of the context of the change for a changelog. It should have a title, examples (if applicable), and why the change was made.
28
18
29
-
**Please keep the changelog title format same as in example below (### <Title>), as this is later used to generate the changelog entry title.**
19
+
<!-- Changelogs are published for our customers. Well-written entries help them stay informed on platform changes and all of the great work that we do! -->
20
+
21
+
<!-- Write a concise description of changes in the relevant section.
22
+
- Add new line items as needed.
23
+
- Entries should follow the [Common Changelog Style Guide](https://github.com/vweevers/common-changelog).
24
+
- Remove all unused sections before merging.
25
+
- Proof-read.
26
+
-->
30
27
31
-
Example for a plugin upgrade:
28
+
### Added
29
+
-<!-- e.g. "Added a new set of filters for MFA status" -->
30
+
-<!-- e.g. "Dev-env: Added PHP 8.3 image" -->
32
31
33
-
### Plugin Updated: Jetpack 9.2.1
32
+
### Removed
33
+
-<!-- e.g. "Dropped support of Node.js 14" -->
34
+
-
35
+
36
+
### Fixed
37
+
-<!-- e.g. "Fixed a bug causing blank lines in content to be ignored when using the Regex Parser" -->
38
+
39
+
### Changed
40
+
-<!-- e.g. "Increased priority of wp_mail_from filter in VIP Dashboard to prevent unintentional overriding" -->
41
+
-<!-- e.g. "HyperDB: Updated to latest version to fix PHP error with addslashes()" -->
34
42
35
-
We upgraded Jetpack 9.2 to Jetpack 9.2.1.
36
43
37
-
Not a lot of significant changes in this patch release, just bugfixes and compatibility improvements.
38
-
-->
39
44
## Pre-review checklist
40
45
41
46
Please make sure the items below have been covered before requesting a review:
42
47
43
-
-[ ] This change works and has been tested locally (or has an appropriate fallback).
44
-
-[ ] This change works and has been tested on a Go sandbox.
48
+
-[ ] This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
49
+
-[ ] This change works and has been tested on a sandbox.
45
50
-[ ] This change has relevant unit tests (if applicable).
46
51
-[ ] This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
47
52
-[ ] This change has relevant documentation additions / updates (if applicable).
@@ -52,6 +57,7 @@ Please make sure the items below have been covered before requesting a review:
52
57
-[ ] VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).
0 commit comments