From 9574dc50d282b481c2c618f65dda8d8e9dde50aa Mon Sep 17 00:00:00 2001 From: Francesco Date: Wed, 26 Feb 2025 16:28:53 +0100 Subject: [PATCH] chore: remove unnecessary useEffect on settings toggle (#10449) --- changelog/chore-remove-unneeded-useeffect-in-settings | 5 +++++ .../settings/advanced-settings/multi-currency-toggle.js | 9 --------- .../advanced-settings/wcpay-subscriptions-toggle.js | 9 --------- 3 files changed, 5 insertions(+), 18 deletions(-) create mode 100644 changelog/chore-remove-unneeded-useeffect-in-settings diff --git a/changelog/chore-remove-unneeded-useeffect-in-settings b/changelog/chore-remove-unneeded-useeffect-in-settings new file mode 100644 index 00000000000..8ce1e20deab --- /dev/null +++ b/changelog/chore-remove-unneeded-useeffect-in-settings @@ -0,0 +1,5 @@ +Significance: patch +Type: dev +Comment: chore: remove unnecessary useEffect on settings toggle + + diff --git a/client/settings/advanced-settings/multi-currency-toggle.js b/client/settings/advanced-settings/multi-currency-toggle.js index 5a285c7c37a..e5033e7e5d5 100644 --- a/client/settings/advanced-settings/multi-currency-toggle.js +++ b/client/settings/advanced-settings/multi-currency-toggle.js @@ -3,7 +3,6 @@ */ import { CheckboxControl, ExternalLink } from '@wordpress/components'; import { __ } from '@wordpress/i18n'; -import { useEffect, useRef } from '@wordpress/element'; /** * Internal dependencies @@ -17,14 +16,6 @@ const MultiCurrencyToggle = () => { updateIsMultiCurrencyEnabled, ] = useMultiCurrency(); - const headingRef = useRef( null ); - - useEffect( () => { - if ( ! headingRef.current ) return; - - headingRef.current.focus(); - }, [] ); - const handleMultiCurrencyStatusChange = ( value ) => { updateIsMultiCurrencyEnabled( value ); }; diff --git a/client/settings/advanced-settings/wcpay-subscriptions-toggle.js b/client/settings/advanced-settings/wcpay-subscriptions-toggle.js index c2b23f5968e..edc2339e506 100644 --- a/client/settings/advanced-settings/wcpay-subscriptions-toggle.js +++ b/client/settings/advanced-settings/wcpay-subscriptions-toggle.js @@ -3,7 +3,6 @@ */ import { CheckboxControl, ExternalLink } from '@wordpress/components'; import { __, sprintf } from '@wordpress/i18n'; -import { useEffect, useRef } from '@wordpress/element'; /** * Internal dependencies @@ -18,14 +17,6 @@ const WCPaySubscriptionsToggle = () => { updateIsWCPaySubscriptionsEnabled, ] = useWCPaySubscriptions(); - const headingRef = useRef( null ); - - useEffect( () => { - if ( ! headingRef.current ) return; - - headingRef.current.focus(); - }, [] ); - const handleWCPaySubscriptionsStatusChange = ( value ) => { updateIsWCPaySubscriptionsEnabled( value ); };