fix: backend currency formatting (#10825)

Author: frosso

changelog/fix-backend-currency-formatting

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+fix: formatting of currencies in the backend will always honor the merchant's settings, rather than the currency locale.

includes/multi-currency/BackendCurrencies.php

@@ -94,13 +94,6 @@ class MultiCurrency {
 	 */
 	protected $frontend_currencies;
 
-	/**
-	 * BackendCurrencies instance.
-	 *
-	 * @var BackendCurrencies
-	 */
-	protected $backend_currencies;
-
 	/**
 	 * StorefrontIntegration instance.
 	 *
@@ -225,7 +218,6 @@ public function init_hooks() {
 			add_filter( 'woocommerce_get_settings_pages', [ $this, 'init_settings_pages' ] );
 			// Enqueue the scripts after the main WC_Payments_Admin does.
 			add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_admin_scripts' ], 20 );
-			add_action( 'admin_head', [ $this, 'set_client_format_and_rounding_precision' ] );
 		}
 
 		add_action( 'init', [ $this, 'init' ] );
@@ -294,15 +286,13 @@ public function init() {
 
 		$this->frontend_prices     = new FrontendPrices( $this, $this->compatibility );
 		$this->frontend_currencies = new FrontendCurrencies( $this, $this->localization_service, $this->utils, $this->compatibility );
-		$this->backend_currencies  = new BackendCurrencies( $this, $this->localization_service );
 		$this->tracking            = new Tracking( $this );
 
 		// Init all of the hooks.
 		$admin_notices->init_hooks();
 		$user_settings->init_hooks();
 		$this->frontend_prices->init_hooks();
 		$this->frontend_currencies->init_hooks();
-		$this->backend_currencies->init_hooks();
 		$this->tracking->init_hooks();
 
 		add_action( 'woocommerce_order_refunded', [ $this, 'add_order_meta_on_refund' ], 50, 2 );
@@ -1100,37 +1090,6 @@ public function update_settings( $params ) {
 		}
 	}
 
-	/**
-	 * Apply client order currency format and reduces the rounding precision to 2.
-	 *
-	 * @return  void
-	 */
-	public function set_client_format_and_rounding_precision() {
-		$screen = get_current_screen();
-		if ( in_array( $screen->id, [ 'shop_order', 'woocommerce_page_wc-orders' ], true ) ) :
-			$order = wc_get_order();
-			if ( ! $order ) {
-				return;
-			}
-			$currency                     = $order->get_currency();
-			$currency_format_num_decimals = $this->backend_currencies->get_price_decimals( $currency );
-			$currency_format_decimal_sep  = $this->backend_currencies->get_price_decimal_separator( $currency );
-			$currency_format_thousand_sep = $this->backend_currencies->get_price_thousand_separator( $currency );
-			$currency_format              = str_replace( [ '%1$s', '%2$s', ' ' ], [ '%s', '%v', ' ' ], $this->backend_currencies->get_woocommerce_price_format( $currency ) );
-
-			$rounding_precision = wc_get_price_decimals() ?? wc_get_rounding_precision();
-			?>
-		<script>
-		woocommerce_admin_meta_boxes.currency_format_num_decimals = <?php echo (int) $currency_format_num_decimals; ?>;
-		woocommerce_admin_meta_boxes.currency_format_decimal_sep = '<?php echo esc_attr( $currency_format_decimal_sep ); ?>';
-		woocommerce_admin_meta_boxes.currency_format_thousand_sep = '<?php echo esc_attr( $currency_format_thousand_sep ); ?>';
-		woocommerce_admin_meta_boxes.currency_format = '<?php echo esc_attr( $currency_format ); ?>';
-		woocommerce_admin_meta_boxes.rounding_precision = <?php echo (int) $rounding_precision; ?>;
-		</script>
-			<?php
-			endif;
-	}
-
 	/**
 	 * Load script with all required dependencies.
 	 *
@@ -1370,21 +1329,7 @@ public function adjust_amount_for_selected_currency( $amount, $apply_charm_prici
 	 * @return string The formatted amount.
 	 */
 	public function get_backend_formatted_wc_price( float $amount, array $args = [] ): string {
-		// Return early if MC isn't enabled or merchant has a single currency.
-		if ( ! self::has_additional_currencies_enabled() || ! WC_Payments_Features::is_customer_multi_currency_enabled() ) {
-			return wc_price( $amount, $args );
-		}
-
-		$has_filter = has_filter( 'wc_price_args', [ $this->backend_currencies, 'build_wc_price_args' ] );
-		if ( false !== $has_filter ) {
-			return wc_price( $amount, $args );
-		}
-
-		add_filter( 'wc_price_args', [ $this->backend_currencies, 'build_wc_price_args' ], 50 );
-		$price = wc_price( $amount, $args );
-		remove_filter( 'wc_price_args', [ $this->backend_currencies, 'build_wc_price_args' ], 50 );
-
-		return $price;
+		return wc_price( $amount, $args );
 	}
 
 	/**