Reduce multiple urgent dispute signals (#8274)

Automattic · Mar 1, 2024 · c8fd975 · c8fd975
1 parent c7a133b
commit c8fd975
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 26 deletions.
diff --git a/client/payment-details/dispute-details/dispute-due-by-date.tsx b/client/payment-details/dispute-details/dispute-due-by-date.tsx
@@ -9,7 +9,8 @@ import moment from 'moment';
 
 const DisputeDueByDate: React.FC< {
 	dueBy: number;
-} > = ( { dueBy } ) => {
+	showRemainingDays?: boolean;
+} > = ( { dueBy, showRemainingDays = true } ) => {
 	const daysRemaining = Math.floor(
 		moment.unix( dueBy ).diff( moment(), 'days', true )
 	);
@@ -20,31 +21,33 @@ const DisputeDueByDate: React.FC< {
 	return (
 		<span className="dispute-steps__steps__response-date">
 			{ respondByDate }
-			<span
-				className={ classNames( {
-					'dispute-steps__steps__response-date--urgent':
-						daysRemaining < 3,
-					'dispute-steps__steps__response-date--warning':
-						daysRemaining < 7 && daysRemaining > 2,
-				} ) }
-			>
-				{ daysRemaining > 0 &&
-					sprintf(
-						// Translators: %d is the number of days left to respond to the dispute.
-						_n(
-							'(%d day left to respond)',
-							'(%d days left to respond)',
-							daysRemaining,
-							'woocommerce-payments'
-						),
-						daysRemaining
-					) }
+			{ showRemainingDays && (
+				<span
+					className={ classNames( {
+						'dispute-steps__steps__response-date--urgent':
+							daysRemaining < 3,
+						'dispute-steps__steps__response-date--warning':
+							daysRemaining < 7 && daysRemaining > 2,
+					} ) }
+				>
+					{ daysRemaining > 0 &&
+						sprintf(
+							// Translators: %d is the number of days left to respond to the dispute.
+							_n(
+								'(%d day left to respond)',
+								'(%d days left to respond)',
+								daysRemaining,
+								'woocommerce-payments'
+							),
+							daysRemaining
+						) }
 
-				{ daysRemaining === 0 &&
-					__( '(Last day today)', 'woocommerce-payments' ) }
-				{ daysRemaining < 0 &&
-					__( '(Past due)', 'woocommerce-payments' ) }
-			</span>
+					{ daysRemaining === 0 &&
+						__( '(Last day today)', 'woocommerce-payments' ) }
+					{ daysRemaining < 0 &&
+						__( '(Past due)', 'woocommerce-payments' ) }
+				</span>
+			) }
 		</span>
 	);
 };

diff --git a/client/payment-details/dispute-details/dispute-steps.tsx b/client/payment-details/dispute-details/dispute-steps.tsx
@@ -115,7 +115,7 @@ export const DisputeSteps: React.FC< Props > = ( {
 				<li>
 					{ createInterpolateElement(
 						__(
-							'Challenge <challengeIcon/> or accept <acceptIcon/> the dispute by <dueByDate/>.',
+							'Challenge <challengeIcon/> or accept <acceptIcon/> the dispute by <dueByDate/>',
 							'woocommerce-payments'
 						),
 						{
@@ -155,6 +155,7 @@ export const DisputeSteps: React.FC< Props > = ( {
 							dueByDate: (
 								<DisputeDueByDate
 									dueBy={ dispute.evidence_details.due_by }
+									showRemainingDays={ false }
 								/>
 							),
 						}