Add AU-specific strings/details to tax modal #10527
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +106 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Jinksi
reviewed
Mar 12, 2025
| // Note – AU GST numbers are actually ABN or ACN numbers. | ||
| // https://vatstack.com/articles/australian-business-number-abn-validation | ||
| // https://business.gov.au/registrations/register-for-taxes/tax-registration-for-your-business | ||
| return __( 'GST Number', 'woocommerce-payments' ); |
There was a problem hiding this comment.
I'm somewhat familiar with this AU side of things, and it seems a bit abnormal to call it a "GST number". Normally, this would instead be labelled as "ABN".
The Stripe Customer Tax ID field labels might serve as an indicator of country-specific terminology, since they've presumably done the hard yards on tax-collecting UX here.
There was a problem hiding this comment.
Good point, thanks for catching that :) in NZ it's the opposite, your GST is your IRD number, but you label it as GST number when appropriate.
There was a problem hiding this comment.
Actually wait – no, my comment explains my reasoning.
The value in this field will be an ABN OR an ACN, depending on the merchant. So we either need to be smarter about which is correct, or have something generic (GST number) and a hint that it would your ABN or ACN.
There was a problem hiding this comment.
But … if AU companies are used to putting an ACN in an ABN field (which could be the case) … then ABN would work fine too 🤷🏻
There was a problem hiding this comment.
AU companies are used to putting an ACN in an ABN field
AFAIK an ACN is not used for GST-related things. A company with an ACN needs to have an ABN as well, which they'll provide to us.
We'll only want the merchant's ABN, as this is what we're required to provide on the tax invoice.
- ACN: 008 672 179
- ABN: 26 008 672 179
Hence why GST Number stood out to me. I agree, it would be OK to use generic wording and the merchant will be OK to figure it out, but we should lean against ambiguity where we can.
There was a problem hiding this comment.
In the URL you shared in the code comments https://vatstack.com/articles/australian-business-number-abn-validation, it looks like they're getting the ABN via the ACN using the ABN lookup tool.
We can do this too, but it is added complexity, when it would be easier to require an ABN from the merchant rather than have to determine the merchant's ABN based on the ACN they've provided.
There was a problem hiding this comment.
Aha! Thanks for digging in to that and clarifying!
There was a problem hiding this comment.
Fixed up here f1904a8 – but feel free to jump on the PR / suggest more.
…c/woocommerce-payments into add/10525-au-biz-details-modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10525
Resolves WOOPMNT-4839
Changes proposed in this Pull Request
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge