Skip to content

Migrate payment method components to TypeScript and further refactor #8976

Open
@timur27

Description

Description

When migrating Affirm & Afterpay/Clearpay payment components to TypeScript in #7388, it was noticed that there are a few more areas for improvement. This issue addresses the migration of other components to TypeScript, reusing as many shared components and types as possible.

Acceptance criteria

  • All the payment method components under client/payment-details/payment-method* are migrated to TS
  • paymentMethodPlaceholders are be re-used (and extended, if needed) between all payment method components
  • It's verified whether checking charge object for payment_method_details is the proper way. If not, this area is improved. See TypeScript migration: Affirm and Afterpay payment details components #8964 (comment) for more details.
  • formatPaymentMethodDetails is shared between components where applicable and possible
  • Payment method details type is re-used/extended
  • Payment method details are correctly displayed under transaction details screen after all the improvements

Additional context

See the comments in #8964 to gather more information about the changes which were discussed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions