Skip to content

Commit 13b860c

Browse files
dognose24claude
andauthored
Stats: drop the settings tooltip notice ids (#113295)
Removing the Traffic page settings tour left traffic_page_settings with no consumers, and traffic_page_highlights_module_settings was already orphaned, so the settings_tool_tips conflict group had nothing left to arbitrate. NoticeIdType derives from the defaults, so dropping the keys is enough; the server may still return them and the extra keys are simply ignored. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent ce4be9a commit 13b860c

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

client/my-sites/stats/hooks/use-notice-visibility-query.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ export const NOTICES_KEY_SHOW_FLOATING_USER_FEEDBACK_PANEL = 'show_floating_user
77

88
const DEFAULT_SERVER_NOTICES_VISIBILITY = {
99
opt_in_new_stats: false,
10-
traffic_page_highlights_module_settings: false,
11-
traffic_page_settings: false,
1210
do_you_love_jetpack_stats: false,
1311
commercial_site_upgrade: false,
1412
// Defaults to hidden until the server includes it in the notices response,
@@ -34,7 +32,6 @@ export type NoticeIdType = keyof Notices;
3432
// These notices are mutually exclusive, so if one is active, the other should be hidden.
3533
// The IDs are sorted by priory from high to low.
3634
const CONFLICT_NOTICE_ID_GROUPS: Record< string, Array< NoticeIdType > > = {
37-
settings_tool_tips: [ 'traffic_page_settings', 'traffic_page_highlights_module_settings' ],
3835
dashboard_notices: [
3936
// Set the highest priority to prevent blocking Stats under any circumstances.
4037
'gdpr_cookie_consent',

0 commit comments

Comments
 (0)