Agents Manager: show the chat on the Site Editor navigation view (#112372)

Revert the navigation-view hiding added in #112164. Remove
`useHideChatOnSiteEditorNavigation` (and its test), the dock's render gate
and layout-manager `isReady` wiring, and the now-unused
`isSiteEditorCanvasEditMode` helper; un-export the admin-bar button IDs and
sidebar class-name constants the hook imported. The `#wpadminbar` height fix
and the `isChatEnabled` rename from that PR are kept.

Co-authored-by: Welly Shen <welly.shen@automattic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: 3 people

packages/agents-manager/src/components/agent-dock/index.tsx

@@ -13,7 +13,6 @@ import { useAgentsManagerContext } from '../../contexts';
 import { useSetupCustomActions } from '../../hooks/custom-actions';
 import useAdminBarIntegration from '../../hooks/use-admin-bar-integration';
 import useAgentLayoutManager from '../../hooks/use-agent-layout-manager';
-import useHideChatOnSiteEditorNavigation from '../../hooks/use-hide-chat-on-site-editor-navigation';
 import useReaderChatPersistence from '../../hooks/use-reader-chat-persistence';
 import { useShouldUseUnifiedAgent } from '../../hooks/use-should-use-unified-agent';
 import { AGENTS_MANAGER_STORE } from '../../stores';
@@ -120,14 +119,8 @@ export default function AgentDock( {
 		[ isReaderChat, setIsOpen ]
 	);
 
-	// The chat can't work on the Site Editor navigation view, so keep the layout
-	// manager idle there — no docking side effects (portal, body classes, tracking)
-	// until the editing canvas opens.
-	const isSiteEditorNavigation = useHideChatOnSiteEditorNavigation();
-
 	const { isDocked, canDock, dock, undock, openSidebar, closeSidebar, createAgentPortal } =
 		useAgentLayoutManager( {
-			isReady: ! isSiteEditorNavigation,
 			defaultDocked: isReaderChat ? false : isPersistedDocked,
 			defaultOpen: isPersistedOpen,
 			desktopMediaQuery,
@@ -380,9 +373,9 @@ export default function AgentDock( {
 		/>
 	);
 
-	// Neither case has a chat to open, so render nothing — otherwise the editor
-	// entry-point buttons below would be dead.
-	if ( ! isChatEnabled || isSiteEditorNavigation ) {
+	// When the chat is disabled there's nothing to open, so render nothing — the editor
+	// entry-point buttons would otherwise be dead.
+	if ( ! isChatEnabled ) {
 		return null;
 	}
 

packages/agents-manager/src/hooks/__tests__/use-hide-chat-on-site-editor-navigation.test.ts

@@ -9,14 +9,14 @@ import type { AgentsManagerSelect } from '@automattic/data-stores';
 import './style.scss';
 
 // Admin bar element selectors
-export const ADMIN_BAR_BUTTON_ID = 'wp-admin-bar-agents-manager';
+const ADMIN_BAR_BUTTON_ID = 'wp-admin-bar-agents-manager';
 const ADMIN_BAR_CHAT_ITEM_ID = 'wp-admin-bar-agents-manager-chat-support';
 const ADMIN_BAR_HISTORY_ITEM_ID = 'wp-admin-bar-agents-manager-chat-history';
 const ADMIN_BAR_GUIDES_ITEM_ID = 'wp-admin-bar-agents-manager-support-guides';
 
 // The standalone AI chat button — the chat's entry point, separate from the Help
 // menu. The wp-admin bar exposes it by ID; Calypso's masterbar by class.
-export const ADMIN_BAR_AI_CHAT_BUTTON_ID = 'wp-admin-bar-agents-manager-ai-chat';
+const ADMIN_BAR_AI_CHAT_BUTTON_ID = 'wp-admin-bar-agents-manager-ai-chat';
 const MASTERBAR_AI_CHAT_BUTTON_SELECTOR = '.masterbar__item-agents-manager-ai-chat';
 
 /**

packages/agents-manager/src/hooks/use-admin-bar-integration/index.tsx

@@ -27,10 +27,9 @@ const FULLSCREEN_BODY_CLASS = 'is-fullscreen-mode';
 // `jetpack/projects/packages/agents-manager/src/js/sidebar-docking-gate.ts`.
 const CHAT_PORTAL_CLASS = 'agents-manager-chat';
 
-// Container classes that reserve layout space for the docked sidebar; the Site
-// Editor navigation-view hook imports these to strip and restore them.
-export const SIDEBAR_CONTAINER_CLASS = 'agents-manager-sidebar-container';
-export const SIDEBAR_OPEN_CLASS = 'agents-manager-sidebar-container--sidebar-open';
+// Container classes that reserve layout space for the docked sidebar.
+const SIDEBAR_CONTAINER_CLASS = 'agents-manager-sidebar-container';
+const SIDEBAR_OPEN_CLASS = 'agents-manager-sidebar-container--sidebar-open';
 const SIDEBAR_CLOSING_CLASS = 'agents-manager-sidebar-container--closing';
 
 function getIsFullscreenGateOpen(): boolean {

packages/agents-manager/src/hooks/use-agent-layout-manager/index.tsx

@@ -11,18 +11,6 @@ export function isSiteEditorContext( environment?: string, currentRoute?: string
 	);
 }
 
-/**
- * True when the Site Editor shows its editing canvas (`?canvas=edit`) rather
- * than the navigation view. Scoped to the Site Editor so other admin pages that
- * happen to carry `?canvas=edit` aren't treated as canvas edit mode.
- */
-export function isSiteEditorCanvasEditMode(): boolean {
-	return (
-		isSiteEditorContext() &&
-		new URLSearchParams( window.location.search ).get( 'canvas' ) === 'edit'
-	);
-}
-
 export function getClientConstructorArguments(
 	environment?: string,
 	currentRoute?: string