Skip to content

Commit 65e340d

Browse files
committed
Pass renderTitleCell args as an object
renderTitleCell took five positional args and this change reordered them (onClick/onKeyUp became href/onClick). A single named-field object removes the positional-order footgun for any future caller.
1 parent 80aa8b0 commit 65e340d

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

  • client/my-sites/stats/videopress-stats-module

client/my-sites/stats/videopress-stats-module/index.jsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class VideoPressStatsModule extends Component {
8484
return Math.max( ...data.map( ( item ) => item[ field ] || 0 ) );
8585
}
8686

87-
renderTitleCell( title, views, maxViews, href, onClick ) {
87+
renderTitleCell( { title, views, maxViews, onClick, href } ) {
8888
const fillPercentage = maxViews > 0 ? ( views / maxViews ) * 100 : 0;
8989
return (
9090
<div className="videopress-stats-module__grid-cell videopress-stats-module__grid-link">
@@ -239,13 +239,13 @@ class VideoPressStatsModule extends Component {
239239
key={ 'videopress-stats-row-' + index }
240240
className="videopress-stats-module__row-wrapper"
241241
>
242-
{ this.renderTitleCell(
243-
row.title,
244-
row.views,
242+
{ this.renderTitleCell( {
243+
title: row.title,
244+
views: row.views,
245245
maxViews,
246-
videoDetailsHref( row.post_id ),
247-
( event ) => showVideoDetails( event, row.post_id )
248-
) }
246+
href: videoDetailsHref( row.post_id ),
247+
onClick: ( event ) => showVideoDetails( event, row.post_id ),
248+
} ) }
249249
<div className="videopress-stats-module__grid-cell videopress-stats-module__grid-metric">
250250
<span
251251
onClick={ () => showStat( 'impressions', row ) }

0 commit comments

Comments
 (0)