Jetpack AI: survive an editorial review implication with no affected_blocks

The structured-output schema lists affected_blocks as required, but the tool is
not strict, so the model can leave it out. Reading .length off it threw
"Cannot read properties of undefined" and unmounted the whole review card over
one missing field.

The field is now optional on the type and guarded at the render site. Paired
with a server-side backfill in wpcom, which repairs already-cached payloads;
this guard covers any that reach an older client.

Author: t-wright

packages/jetpack-ai-sidebar/src/components/ai-editorial-review.test.tsx

@@ -465,6 +465,23 @@ describe( 'AiEditorialReview — smoke render', () => {
 		expect( mockedRecordTracksEvent ).not.toHaveBeenCalled();
 	} );
 
+	it( 'renders an implication that omits affected_blocks', () => {
+		// The tool schema marks affected_blocks required but the tool is not strict,
+		// so the model can omit it. Indexing it directly used to blank the card.
+		render(
+			<AiEditorialReview
+				{ ...basePayload( {
+					implications: [
+						{ change: 'Tone shift', implies: 'May affect downstream FAQ wording.' },
+					] as any,
+				} ) }
+			/>
+		);
+
+		expect( screen.getByText( 'Tone shift' ) ).toBeInTheDocument();
+		expect( screen.queryByText( 'Affects:' ) ).not.toBeInTheDocument();
+	} );
+
 	it( 'does not tag a stale AER edit "Manual edit" even when the source text is absent', () => {
 		// Editor moved to post 999 (stale) AND the current block doesn't contain the
 		// edit's source text — so the frontend reason is truthy. Without the

packages/jetpack-ai-sidebar/src/components/ai-editorial-review.tsx

@@ -73,7 +73,7 @@ interface Conflict {
 interface Implication {
 	change: string;
 	implies: string;
-	affected_blocks: number[];
+	affected_blocks?: number[];
 }
 
 interface SuggestedEdit {
@@ -1389,27 +1389,33 @@ export default function AiEditorialReview( {
 									onToggle={ ( next: boolean ) => setSectionOpen( 'implications', next ) }
 								>
 									<ul>
-										{ implications.map( ( imp, i ) => (
-											<li key={ `imp-${ i }` }>
-												<strong>{ imp.change }</strong> — { imp.implies }
-												{ imp.affected_blocks.length > 0 && (
-													<span className="jetpack-ai-editorial-review__affected-blocks">
-														{ ' ' }
-														{ __( 'Affects:', __i18n_text_domain__ ) }{ ' ' }
-														{ imp.affected_blocks.map( ( b, j ) => (
-															<span key={ `imp-${ i }-aff-${ j }` }>
-																{ j > 0 && ', ' }
-																<BlockRef
-																	index={ b }
-																	blocks={ blocks }
-																	onFocus={ focusCurrentPostBlock }
-																/>
-															</span>
-														) ) }
-													</span>
-												) }
-											</li>
-										) ) }
+										{ implications.map( ( imp, i ) => {
+											// A non-strict payload can omit affected_blocks.
+											const affectedBlocks = Array.isArray( imp.affected_blocks )
+												? imp.affected_blocks
+												: [];
+											return (
+												<li key={ `imp-${ i }` }>
+													<strong>{ imp.change }</strong> — { imp.implies }
+													{ affectedBlocks.length > 0 && (
+														<span className="jetpack-ai-editorial-review__affected-blocks">
+															{ ' ' }
+															{ __( 'Affects:', __i18n_text_domain__ ) }{ ' ' }
+															{ affectedBlocks.map( ( b, j ) => (
+																<span key={ `imp-${ i }-aff-${ j }` }>
+																	{ j > 0 && ', ' }
+																	<BlockRef
+																		index={ b }
+																		blocks={ blocks }
+																		onFocus={ focusCurrentPostBlock }
+																	/>
+																</span>
+															) ) }
+														</span>
+													) }
+												</li>
+											);
+										} ) }
 									</ul>
 								</PanelBody>
 							</div>