Plugins "Get started": fix blank page + duplicate site when backing out of checkout - #112462
Merged
Merged
Conversation
…e or duplicate site Backing out of checkout in the with-plugin flow had two problems: - The back URL dropped the required billing_period query dependency for free plugins, so the flow controller threw and the plans step rendered blank. Always include billing_period (empty for free plugins). - Re-entering the flow restarted at the domains step and created a duplicate site. Extend the existing onboarding "skip domains on browser-back" path (persist domains data on completion, re-submit it on re-entry) to the with-plugin flow, so it reuses the created site and lands on the plans grid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
…ow flag Replace the duplicated [ 'onboarding', 'with-plugin' ] flow-name list in controller.js and main.jsx with a persistsDomainsOnReEntry flag on the flow config, mirroring the existing excludeFromManageSiteFlows pattern. A flow now opts into the domains-persist/skip-on-browser-back behavior in one place instead of two lists that must stay in sync. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…field Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
taipeicoder
marked this pull request as ready for review
July 9, 2026 09:26
taipeicoder
added this pull request to the merge queue
Jul 9, 2026
Contributor
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~46 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix backing out of checkout in the per-plugin "Get started" (
with-plugin) flow, which had two separate failures:billing_periodquery dependency for free plugins (which have no billing period), so the flow controller rejected the URL and the plans step rendered blank. It now always includesbilling_period(empty for free plugins).with-pluginflow.Net result: backing out of checkout lands on the plans grid with the plugin selected — no blank page, no duplicate site.
Testing Instructions
Unit tests in
client/signup/test/flows.jscover the back URL carryingbilling_periodfor both paid and free plugins. The domains-skip behavior was verified manually for both plugin types.Pre-merge Checklist