Skip to content

Dashboard: add trailing period to On this day reminder help text - #112464

Merged
alshakero merged 1 commit into
trunkfrom
update/on-this-day-help-text-period
Jul 9, 2026
Merged

Dashboard: add trailing period to On this day reminder help text#112464
alshakero merged 1 commit into
trunkfrom
update/on-this-day-help-text-period

Conversation

@alshakero

Copy link
Copy Markdown
Member

Proposed Changes

  • Add a trailing period to the "On this day" toggle help text in the Notifications → Extras screen: "Reminders about your posts from past years."
  • Update the corresponding unit test assertion to match.

Why are these changes being made?

  • The help text was missing a terminating period, unlike the surrounding help copy on the screen. This is a small copy consistency fix.

Testing Instructions

  • Run yarn test-client client/dashboard/me/notifications-extras.
  • In the dashboard, go to Notifications → Extras and confirm the "On this day" toggle help text ends with a period.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • For UI changes, have you tested the affected components in dark mode?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@alshakero
alshakero marked this pull request as ready for review July 9, 2026 10:08
@alshakero
alshakero requested a review from a team as a code owner July 9, 2026 10:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 9, 2026
@alshakero
alshakero enabled auto-merge July 9, 2026 10:08
@alshakero
alshakero added this pull request to the merge queue Jul 9, 2026
Merged via the queue into trunk with commit e4dd988 Jul 9, 2026
18 checks passed
@alshakero
alshakero deleted the update/on-this-day-help-text-period branch July 9, 2026 10:25
@github-actions github-actions Bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 9, 2026
@a8ci18n

a8ci18n commented Jul 9, 2026

Copy link
Copy Markdown

Translation for this Pull Request has now been finished.

@matticbot

Copy link
Copy Markdown
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants