Skip to content

Fix editor schedule E2E flakes - #112465

Closed
MaggieCabrera wants to merge 3 commits into
trunkfrom
codex/fix-editor-schedule-e2e-flakes
Closed

Fix editor schedule E2E flakes#112465
MaggieCabrera wants to merge 3 commits into
trunkfrom
codex/fix-editor-schedule-e2e-flakes

Conversation

@MaggieCabrera

@MaggieCabrera MaggieCabrera commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Part of Gutenberg-on-WPCOM v23.5.1 rotation.

Proposed Changes

  • Match only the canonical post/page save response in EditorPage.publish(), so publish waits do not accidentally capture child endpoints such as autosaves.
  • Skip Calypso shell/sidebar stabilization when editor__schedule.ts authenticates the second user before immediately navigating to the published post URL.

Why are these changes being made?

  • The Atomic Edge desktop schedule test could catch a publish-time child REST response that does not include the published article link, causing No published article URL found in response.
  • The Atomic Edge mobile schedule test was waiting for a dashboard sidebar during a step that only needs authenticated cookies before navigating to public content.

Testing Instructions

  • git diff --check
  • ESLINT_USE_FLAT_CONFIG=false node .yarn/releases/yarn-4.0.2.cjs eslint packages/calypso-e2e/src/lib/pages/editor-page.ts test/e2e/specs/editor/editor__schedule.ts
  • node .yarn/releases/yarn-4.0.2.cjs workspace @automattic/calypso-e2e build
  • Atomic Edge desktop: CALYPSO_BASE_URL=https://wordpress.com TEST_ON_ATOMIC=true GUTENBERG_EDGE=true AUTHENTICATE_ACCOUNTS=defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts — 16/16 passed.
  • Atomic Edge mobile: CALYPSO_BASE_URL=https://wordpress.com TEST_ON_ATOMIC=true GUTENBERG_EDGE=true VIEWPORT_NAME=mobile AUTHENTICATE_ACCOUNTS=defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts — 16/16 passed.
  • Simple Edge desktop: CALYPSO_BASE_URL=https://wordpress.com GUTENBERG_EDGE=true AUTHENTICATE_ACCOUNTS=gutenbergSimpleSiteEdgeUser,defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts — 16/16 passed.
  • Simple Edge mobile: CALYPSO_BASE_URL=https://wordpress.com GUTENBERG_EDGE=true VIEWPORT_NAME=mobile AUTHENTICATE_ACCOUNTS=gutenbergSimpleSiteEdgeUser,defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts — 16/16 passed.
  • Self-hosted Jetpack is not applicable to this spec: the repository has no supported remote-site editor/schedule suite exercising these paths. A manual JETPACK_TARGET=remote-site attempt stopped in the WPCOM-specific editor-load heuristic before reaching the publish response matching changed here.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • For UI changes, have you tested the affected components in dark mode?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Looks like one of the E2E tests has failed.

You can fix them following these steps:

  1. Check out this branch locally:
    gh pr checkout 112465
  2. Start Claude Code in the repo:
    claude
  3. Run the /fix-e2e-tests skill, passing this PR number:
    /fix-e2e-tests 112465
    

@matticbot

Copy link
Copy Markdown
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@MaggieCabrera

MaggieCabrera commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

This PR might not be needed anymore, since the tests are passing, but I'll leave it here in case it reoccurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants