Fix editor schedule E2E flakes - #112465
Closed
MaggieCabrera wants to merge 3 commits into
Closed
Conversation
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
|
Looks like one of the E2E tests has failed. You can fix them following these steps:
|
Contributor
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Collaborator
Author
|
This PR might not be needed anymore, since the tests are passing, but I'll leave it here in case it reoccurs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Gutenberg-on-WPCOM v23.5.1 rotation.
Proposed Changes
EditorPage.publish(), so publish waits do not accidentally capture child endpoints such as autosaves.editor__schedule.tsauthenticates the second user before immediately navigating to the published post URL.Why are these changes being made?
No published article URL found in response.Testing Instructions
git diff --checkESLINT_USE_FLAT_CONFIG=false node .yarn/releases/yarn-4.0.2.cjs eslint packages/calypso-e2e/src/lib/pages/editor-page.ts test/e2e/specs/editor/editor__schedule.tsnode .yarn/releases/yarn-4.0.2.cjs workspace @automattic/calypso-e2e buildCALYPSO_BASE_URL=https://wordpress.com TEST_ON_ATOMIC=true GUTENBERG_EDGE=true AUTHENTICATE_ACCOUNTS=defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts— 16/16 passed.CALYPSO_BASE_URL=https://wordpress.com TEST_ON_ATOMIC=true GUTENBERG_EDGE=true VIEWPORT_NAME=mobile AUTHENTICATE_ACCOUNTS=defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts— 16/16 passed.CALYPSO_BASE_URL=https://wordpress.com GUTENBERG_EDGE=true AUTHENTICATE_ACCOUNTS=gutenbergSimpleSiteEdgeUser,defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts— 16/16 passed.CALYPSO_BASE_URL=https://wordpress.com GUTENBERG_EDGE=true VIEWPORT_NAME=mobile AUTHENTICATE_ACCOUNTS=gutenbergSimpleSiteEdgeUser,defaultUser HEADLESS=true JEST_E2E_WORKERS=1 node ../../.yarn/releases/yarn-4.0.2.cjs test specs/editor/editor__schedule.ts— 16/16 passed.JETPACK_TARGET=remote-siteattempt stopped in the WPCOM-specific editor-load heuristic before reaching the publish response matching changed here.Pre-merge Checklist