Reader Spaces: add membership lookup, drop dead per-source feed mutations - #112468
Draft
mlaetitia wants to merge 2 commits into
Draft
Reader Spaces: add membership lookup, drop dead per-source feed mutations#112468mlaetitia wants to merge 2 commits into
mlaetitia wants to merge 2 commits into
Conversation
…ions
Add the read-only membership endpoint (GET /reader/spaces/membership) across
the three data layers: fetchReadSpaceMembership + adapter/types (api-core),
readSpaceMembershipQuery (api-queries), and the useSpaceMembership consumer
hook, with tests and docs. It answers "which of my spaces already contain
this feed/tag?" without loading every space's full source list.
Remove the dead addReadSpaceSource/deleteReadSpaceSource mutators, their
mutation factories, the ReadSpaceSourceMutationParams type, and their tests:
the POST/DELETE /reader/spaces/{id}/feeds routes no longer exist on the
backend, so nothing could call them. Membership changes go through the bulk
PUT /reader/spaces/{id}.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~5 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~5 bytes removed 📉 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
GET /reader/spaces/membership, acrossapi-core(fetcher/adapter/types),api-queries(readSpaceMembershipQuery), and auseSpaceMembershiphook. Answers "which of my spaces already contain this feed/tag?"addReadSpaceSource/deleteReadSpaceSourcemutators + factories + type — their/feedsroutes no longer exist on the backend.Why are these changes being made?
PUT.Testing Instructions
yarn test-packages read-spaces(55 pass);yarn typecheck-client/typecheck-packagesclean.Pre-merge Checklist