Themes "with-theme": fix free .org theme install hanging after signup - #112473
Closed
taipeicoder wants to merge 1 commit into
Closed
Themes "with-theme": fix free .org theme install hanging after signup#112473taipeicoder wants to merge 1 commit into
taipeicoder wants to merge 1 commit into
Conversation
A free .org theme installed via /start/with-theme redirects to the same
marketplace install page as free plugins, which initiates the transfer only
when the in-memory purchase-flow handoff is present. That handoff doesn't
survive the redirect out of signup, so the page polled the site forever
("Putting the pieces together") instead of installing. Mark the redirect as
trusted (directInstall) so the page initiates the install directly — the same
fix already shipped for the free-plugin path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
.orgtheme installed via thewith-themesignup flow hanging on a blank "Putting the pieces together" screen after signup.getWithThemeDestinationsends.orgthemes to the same marketplace install page as free plugins (/marketplace/theme/:theme/install/:site), which only initiates the atomic transfer + install when the in-memory purchase-flow handoff is present. That handoff doesn't survive the full-page redirect out of signup, so the page polled the site indefinitely. The redirect is now marked trusted (?directInstall=1) so the install page initiates the transfer/install itself.Why are these changes being made?
This is the theme counterpart of the free-plugin install hang already fixed for the
with-pluginflow — the two flows route to the same install page, and the install page already readsdirectInstallfor theme installs (its init effect handleswpOrgTheme), so this is a one-line parity fix.Testing Instructions
with-themeflow with a free.orgtheme and a paid plan in the cart.No unit test added:
getWithThemeDestinationis not exported and has no existing coverage (its siblings mock the function rather than exercise it); thedirectInstallmechanism it relies on is already shipped and exercised via the free-plugin path.Pre-merge Checklist