Skip to content

A4A: Use the new badge style on all the A4A pages - #113258

Open
yashwin wants to merge 4 commits into
trunkfrom
fix/a4a-3045-woopayments-labels-info-icon
Open

A4A: Use the new badge style on all the A4A pages#113258
yashwin wants to merge 4 commits into
trunkfrom
fix/a4a-3045-woopayments-labels-info-icon

Conversation

@yashwin

@yashwin yashwin commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Resolves A4A-3045

Proposed Changes

  • Update the status labels on several screens to the new badge style already used on WooPayments, Referrals, and Migrations, so labels look the same across the product:
    • Reports — the report status labels (Preparing, Ready to send, Sent, Error).
    • Amplify — the “Audit complete” label on the overview card, and the score and analysis-type labels on the reports list.
    • Partner Directory — the directory application statuses (Pending, Approved, Not approved, Closed) and the lead matching eligibility labels.
    • Payment settings pages for Referrals, Migrations, and WooPayments commissions — the “Payment status” label in the page header.
    • Sidebar — the “Beta” tags next to Reports, Amplify, and menu items like Agent Studio.
    • Overview — the “Featured” tag on the WooPayments card now uses the standard badge with no custom styling.
    • Sites — the “Development” and “Migration in progress” labels on the site list.
    • Marketplace — the “You own N sites” tag and the Pressable “Plan” tag.
    • Purchases — the license labels (Unassigned, Revoked, Transferred, Referral, Development, license bundle count, Refundable) and the invoice statuses (Draft, Open, Past due, Paid, Uncollectible, Void).
    • Referrals — the payment status label on the “Prepare to get paid” step of the overview, which was also getting cut off before.
    • Client dashboard — the subscription status labels clients see (Active, Pending, Error, Canceled).
  • Labels that are categories rather than statuses (Beta, Development, Referral, analysis type, bundle count) use the neutral gray badge, since the new badge set doesn’t include the old custom colors.
  • Wide license labels like “100 License Bundle” are no longer cut off, and the invoice status column is slightly wider so “Uncollectible” fits on one line.

Why are these changes being made?

  • Some screens still used the old badge design while newer screens use the new one, so the same kind of label looked different from page to page. This was raised in the A4A dashboard QA walkthrough (A4A-3045).

Testing Instructions

  • Open the live link for this branch (A8C for Agencies) and log in as an agency.
  • Go to Reports — the status column should show the new-style labels with icons.
Screenshot 2026-08-04 at 3 37 40 PM
  • Go to Amplify — the overview card shows the new “Audit complete” label; on the reports list, the score labels and analysis-type labels use the new style.
Screenshot 2026-08-04 at 3 44 37 PM Screenshot 2026-08-04 at 3 49 15 PM
  • Go to Partner Directory — the “Share your expertise” step shows the directory statuses in the new style; the “Not approved” popover still opens. Also check the status card on the Lead matching page.
Screenshot 2026-08-04 at 3 33 55 PM Screenshot 2026-08-04 at 3 34 39 PM Screenshot 2026-08-04 at 3 36 57 PM Screenshot 2026-08-04 at 3 40 10 PM
  • Go to Referrals → Payment settings (and the same page under Migrations and WooPayments) — the “Payment status” label in the header uses the new style; when the account has an issue, hovering it shows the reason in a tooltip.
Screenshot 2026-08-04 at 3 59 31 PM
  • Check the sidebar — the “Beta” tags next to Reports, Amplify, and Agent Studio use the new neutral badge.
Screenshot 2026-08-06 at 11 37 14 AM
  • Go to Overview — the WooPayments card shows the “Featured” tag as a standard badge.
Screenshot 2026-08-06 at 12 32 18 PM
  • Go to Sites — dev sites show the gray “Development” label; sites mid-migration show the blue “Migration in progress” label.
Screenshot 2026-08-06 at 11 59 49 AM Screenshot 2026-08-06 at 12 01 36 PM
  • Go to Marketplace → Hosting — the WordPress.com plan card shows the “You own N sites” tag, and the Pressable section shows the “Plan” tag next to your plan name.
Screenshot 2026-08-06 at 11 55 41 AM Screenshot 2026-08-06 at 11 55 49 AM
  • Go to Purchases → Licenses — check the labels across the tabs: “Unassigned” (yellow), “Revoked” (red), and the gray tags (Development, Referral, bundle count). Wide labels like “100 License Bundle” should not be cut off.
Screenshot 2026-08-06 at 11 57 52 AM Screenshot 2026-08-06 at 11 58 14 AM Screenshot 2026-08-06 at 11 58 22 AM Screenshot 2026-08-06 at 12 00 47 PM
  • Go to Purchases → Invoices — the status column shows the new labels; “Uncollectible” fits on one line.
Screenshot 2026-08-06 at 12 27 11 PM
  • Go to Referrals with an account that has no referrals — the “Prepare to get paid” step shows the payment status label next to the heading, fully visible (it was truncated before).
Screenshot 2026-08-06 at 12 50 43 PM Screenshot 2026-08-06 at 12 50 59 PM
  • Log in as a client and open the subscriptions list — the status column shows the new-style labels (Active, Pending, Error, Canceled).
Screenshot 2026-08-06 at 12 52 35 PM Screenshot 2026-08-06 at 12 52 58 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • For UI changes, have you tested the affected components in dark mode?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

…and payment settings

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@yashwin
yashwin requested a review from a team August 4, 2026 10:26
@yashwin yashwin self-assigned this Aug 4, 2026
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 4, 2026
@yashwin
yashwin marked this pull request as ready for review August 4, 2026 10:31
yashwin and others added 3 commits August 6, 2026 12:29
…etplace, and Purchases

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@yashwin
yashwin force-pushed the fix/a4a-3045-woopayments-labels-info-icon branch from b6ca05e to 7234ec2 Compare August 6, 2026 07:25
@yashwin yashwin changed the title A4A: Use the new badge style on Reports, Amplify, Partner Directory, and payment settings A4A: Use the new badge style on all the A4A pages Aug 6, 2026
@jkguidaven

jkguidaven commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

For the subscription list (Client), can we use the Grey intent for the 'canceled' status? To match closely the one we already have.

Screenshot 2026-08-07 at 9 23 12 PM

Same goes for PD's 'closed' status too.

Screenshot 2026-08-07 at 9 34 15 PM

@jkguidaven

Copy link
Copy Markdown
Contributor

Leftover style for the old badge in pressable-usage-section/style.scss:

.badge.badge--info {
	@include body-small;
	background-color: var( --color-neutral-0 );
}

The badge in that section now uses the new component, so this rule no longer applies to anything. The same leftovers were removed in featured-woopayments, wpcom-plan-section, reports-content, and sites-dataviews — this one looks like it was just missed.

@jkguidaven

Copy link
Copy Markdown
Contributor

Flagged by AI while reviewing this branch — could you confirm whether these were left out on purpose?

Three places still use the old badge:

  • Sidebar “Payout settings” indicator (Referrals, Migrations, WooPayments) — components/step-section-item/status-badge.tsx
  • Site tags in the Sites preview panecomponents/agency-site-tag/index.tsx
  • Marketplace cart countsections/marketplace/shopping-cart/index.tsx

All three still show up in the UI today, so they aren’t dead code. Two of them display a number instead of text and one has an icon inside, so they may not fit the new badge cleanly — which would be a reasonable reason to skip them.

@jkguidaven jkguidaven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it works great! I left minor comments, but feel free to address them before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A8c Agencies [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants