Dashboard: warn when the account email address is bouncing - #113360
Draft
leonardost wants to merge 2 commits into
Draft
Dashboard: warn when the account email address is bouncing#113360leonardost wants to merge 2 commits into
leonardost wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRxJcPXk1VER7bjwek5AZF
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRxJcPXk1VER7bjwek5AZF
Contributor
|
WordPress.com
Automattic for Agencies
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DOTOBRD-370
Proposed Changes
user_email_bouncingboolean on/me/settings, prefetched in thesitesRouteloader so the banner is settled before first paint.This is the frontend half. The wpcom
/me/settingschange is separate. Either half can land first: with the field absent the notice stays hidden, so this is safe to merge before the API change deploys.Why are these changes being made?
A user whose account email no longer accepts mail cannot recover their account — both the password reset and the login link need a working inbox, and the only email-free route asks for a username that is usually autogenerated and unknown to the user. 7.9% of lockout tickets come from a bouncing account email.
We cannot email these users to tell them; that is the problem itself. Many of them can still sign in, so the dashboard is the only channel we have to reach them.
The field is derived from the current account email, so it flips to
falseon its own once the user completes an email change. There is no dismissal state and nothing to clean up.Testing Instructions
/sites./me/settingsreturnsuser_email_bouncing: true. The warning appears above the site list, showing the account email address, with no dismiss button./me/accountand the secondary to/me/security/account-recovery.Automated coverage:
yarn test-client client/dashboard/app/account-email-bouncing-notice client/dashboard/sites/test/index.test.tsxNote on the shared test helper:
render()inclient/dashboard/test-utils.tsxgains an optionalconfigoption. The default app config used by tests hassupports.me: false, so a test could not otherwise exercise a notice gated on it. The option is additive with the previous config as its default, so no existing test changes behavior.Pre-merge Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01TRxJcPXk1VER7bjwek5AZF