PathIcon does not respect parent Foreground

[sn4k3]

I was having trouble to make styled buttons with icons where I have classes to adjust button background, eg: Success button with darkgreen background and white foreground. Defining the content with a Stackpanel( PathIcon + Text ) makes my button design broken: because Icon will be black and text white.... Manual set icon foreground is not desired because theme can change...
After some time finding the issue I found that PathIcon have a forced foreground by default: <Setter Property="Foreground" Value="{DynamicResource TextControlForeground}" />. Why is that decision? I think PathIcon should always follow the parent foreground unless stated, even if we use PathIcon directly on a Window the foreground will match the theme color, so why foreground is forced in avalonia theme?

[andrewwong0893]

my experience with Path and Fill has been more successful

<Viewbox HorizontalAlignment="Center" VerticalAlignment="Center">
    <Path Data="{TemplateBinding Icon, Converter={StaticResource IconToGeometryConverter}}" Fill="{TemplateBinding Foreground}" />
</Viewbox>

[sn4k3]

Yeah, for authoring your controls would be better, but for consuming it's an annoying to have PathIcon with a "forced" foreground.
Obviously we can override the default theme but my question regarding this is to understand if it was made on purpose or more of a bug. To me doesn't make sense to force foreground on this control...
Also Width and Height debatable...

[maxkatz6]

Why is that decision?

It was inherited from UWP, from where this style was ported (together with the rest of the control).
In UWP you don't have the same level of inherited properties like in Avalonia or WPF.

Ideally, yes, it should be changed. But it's also a breaking change. With 12.0 release it might be a good idea.

[sn4k3]

It was inherited from UWP, from where this style was ported (together with the rest of the control).
In UWP you don't have the same level of inherited properties like in Avalonia or WPF.

I understand, but this represents some "careless" when porting features. Gladly Avalonia is not a 1:1 of UWP and sadly when asking for good to have or features, I often see the answer: "Because UWP/WPF does not have it, so we have no intention to implement that". Avalonia is so much better than WPF but still we are acting like we should follow WPF implementations to the risk, degrading some potential features.
In this case, we have Foreground inheritance, at porting time a reflection should been made in a way of "What could we improve here" other than clone, making it better for the users. In current avalonia system for the dev, does not make sense to set a PathIcon or any other font alike component and don't expect it colors not to follow the parent...
The PathIcon could also make use of BorderBrush, BorderThickness, CornerRadius, Padding, as the root element is a Border, does not hurt nor invalidate the actual concept, things that should have been implemented aiming to improve the control.

Ideally, yes, it should be changed. But it's also a breaking change. With 12.0 release it might be a good idea.

If so, should I submit a ticket under issues?

[maxkatz6]

Yes, an issue would be helpful