Skip to content

FontManager auto-registers itself instead of being registered in Application::RegisterServices #10081

New issue
New issue
Open
#19600
Open
FontManager auto-registers itself instead of being registered in Application::RegisterServices#10081
#19600
Labels
enhancement
@kekekeks

Description

@kekekeks
kekekeks
opened on Jan 25, 2023

We should never use this pattern:

Avalonia/src/Avalonia.Base/Media/FontManager.cs

Lines 39 to 58 in cdc7bf3

public static FontManager Current
{
get
{
var current = AvaloniaLocator.Current.GetService<FontManager>();
if (current != null)
{
return current;
}
var fontManagerImpl = AvaloniaLocator.Current.GetRequiredService<IFontManagerImpl>();
current = new FontManager(fontManagerImpl);
AvaloniaLocator.CurrentMutable.Bind<FontManager>().ToConstant(current);
return current;
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions