Skip to content

Add Abstract ColorViewBase for Shared Properties Between ColorPicker and ColorView #21110

Description

@robloo

Is your feature request related to a problem? Please describe.

ColorPicker currently duplicates the entire ColorView's control template within it's own control template. The full reasons for this are outlined here:

#19663 (comment)

Describe the solution you'd like

@rabbitism Noted it should be possible to pull out the common properties into a ColorViewBase class.

    public abstract class ColorViewBase : TemplatedControl
    {
        // All ColorView property definitions
    }

    public class ColorView : ColorViewBase
    public class ColorPicker : ColorViewBase

Describe alternatives you've considered

The alternative is what we have today. Duplication in the XAML control templates and ColorPicker derives from ColorView.

Additional context

This probably needs to be done at the next major release due to the breaking changes in the control hierarchy.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions