Fix hidden Win32 TrayIcon appearing after icon updates - #22125
Merged
MrJul merged 1 commit intoSep 2, 2026
Conversation
…urrent tray icon registration state when updating its icon, so a hidden TrayIcon remains hidden until SetIsVisible(true) is called.
|
You can test this PR using the following package version. |
MrJul
pushed a commit
to MrJul/Avalonia
that referenced
this pull request
Sep 2, 2026
…urrent tray icon registration state when updating its icon, so a hidden TrayIcon remains hidden until SetIsVisible(true) is called. (AvaloniaUI#22125)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Preserves the current Win32 tray icon registration state when its icon is updated.
A hidden
TrayIconnow remains hidden untilSetIsVisible(true)is called.What is the current behavior?
TrayIconImpl.SetIconcallsUpdateIcon()without considering whether the tray icon is currently registered.When
_iconAddedisfalse,UpdateIcon()executesShell_NotifyIcon(NIM.ADD, ...), causing a hidden or initializingTrayIconto unexpectedly appear in the Windows system tray.For example, updating the icon after hiding it can make it visible again:
What is the updated/expected behavior with this PR?
Updating the icon preserves the current registration state:
SetIsVisible(true)is called.To test the change:
TrayIcon.IsVisibletofalse.Icon.IsVisibletotrueand verify that it appears.How was the solution implemented (if it's not obvious)?
When the tray icon is already registered, it is updated normally. When it is not registered, updating its icon does not add it to the system tray.