Fix macOS accent color not respecting the current theme - #22143
Merged
Conversation
MrJul
added
bug
os-macos
customer-priority
maxkatz6
approved these changes
Sep 4, 2026
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes the accent color reported for macOS being incorrect after a system appearance (theme) change.
It turns out the accent color is slightly different between the light and dark theme, so this can easily be missed.
For example, the color of the Purple accent is
#A550A7on the dark theme, but#953D96on the light one.What is the current behavior?
The accent color is always reported with the system appearance that was used when the application started.
Note that accent color changes are reported and read, but the actual value isn't correct.
What is the updated/expected behavior with this PR?
The reported accent color matches the current appearance.
How was the solution implemented (if it's not obvious)?
NSColor.controlAccentColoruses thecurrentDrawingAppearance, which is a thread-local value that might not correspond to the actual system appearance.NSApp.effectiveAppearanceis now forced as the current drawing appearance before retrieving the value.