-
Notifications
You must be signed in to change notification settings - Fork 194
Open
Description
I suggest removing the orginal (obsolete) syntax highlighting code in the AvaloniaEdit.
Background info:
The original AvalonEdit implementation used its own highlighting engine. AvaloniaEdit instead uses TextMate.
The original highlighting code is still included but not used anywhere. See folder src/AvaloniaEdit/Highlighting.
Pros:
AvaloniaEdit.dllshrinks by 25%. 662 KB → 502 KB, measured on Win11, .NET 8, Release build.- Maintain/support only the modern highlighting implementation. Remove obsolete/unmaintained/unsupported code path.
Cons:
- Breaking change.
- A 1:1 app port from WPF
AvalonEdittoAvaloniaEditwill not have syntax highlighting. It is easy to switch to TextMate, but it will not be possible to use custom AvalonEdit XML syntax highlighting definition files (.xshd files). - The
HtmlClipboardandRichTextclasses will have to be removed. Most users probably have never heard of these features in AvaloniaEdit. ;)
Let me know what you think! I can provide the PR – the change is fairly trivial.
If not now then maybe we should consider this for v12?
Metadata
Metadata
Assignees
Labels
No labels