Fixed score deails not available

Avasam · Jul 24, 2020 · 5ba4da6 · 5ba4da6
1 parent c6d6c9b
commit 5ba4da6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/global-scoreboard/.eslintrc.json b/global-scoreboard/.eslintrc.json
@@ -56,6 +56,8 @@
         }
       }
     ],
-    "sort-imports": "error"
+    "sort-imports": "error",
+    // False positives should be infered from Typescript
+    "react/prop-types": "off"
   }
 }
diff --git a/global-scoreboard/src/Dashboard/TableElements/PlayerScoreCell.tsx b/global-scoreboard/src/Dashboard/TableElements/PlayerScoreCell.tsx
@@ -1,4 +1,3 @@
-
 import './PlayerScoreCell.css'
 import React, { useState } from 'react'
 import { Button } from 'react-bootstrap'
@@ -15,7 +14,7 @@ const PlayerScoreCell = (props: PlayerScoreCellProps) => {
 
   const handleClose = () => setShow(false)
   const handleShow = () =>
-    props.player.scoreDetails == null
+    props.player.scoreDetails === undefined
       ? apiGet(`players/${props.player.userId}/score-details`)
         .then(res =>
           res.text().then(scoreDetails => {
@@ -25,7 +24,8 @@ const PlayerScoreCell = (props: PlayerScoreCellProps) => {
         )
       : setShow(true)
 
-  return !props.player.scoreDetails
+  // Date is last known update date for a user with details
+  return props.player.lastUpdate < new Date('2020-05-19')
     ? <span>{props.player.score}</span>
     : <>
       <Button
@@ -40,7 +40,11 @@ const PlayerScoreCell = (props: PlayerScoreCellProps) => {
         title={`Runner: ${props.player.name} (${props.player.userId}), ${props.player.score} pts`}
       >
         <div className="alert alert-success">
-          {props.player.scoreDetails}
+          {props.player.scoreDetails
+            ? props.player.scoreDetails
+            : ('No details available. ' +
+              `You can update ${props.player.name} (${props.player.userId}) to get more details about their runs.`)
+          }
         </div>
       </GenericModal>
     </>