Skip to content

Commit d900a93

Browse files
committed
Remove optick
1 parent 394ed34 commit d900a93

21 files changed

+49
-52
lines changed

.gitmodules

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@
2525
[submodule "extern/nativefiledialog-extended"]
2626
path = extern/nativefiledialog-extended
2727
url = https://github.com/btzy/nativefiledialog-extended
28-
[submodule "extern/optick"]
29-
path = extern/optick
30-
url = https://github.com/AxioDL/optick.git
31-
branch = master
3228
[submodule "extern/aurora"]
3329
path = extern/aurora
3430
url = https://github.com/encounter/aurora.git

Runtime/AutoMapper/CMapArea.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ CMapArea::CMapArea(CInputStream& in, u32 size)
7878
}
7979

8080
void CMapArea::PostConstruct() {
81-
OPTICK_EVENT();
81+
// OPTICK_EVENT();
8282
x38_moStart = x44_buf.get();
8383
x3c_vertexStart = x38_moStart + (x28_mappableObjCount * 0x50);
8484
x40_surfaceStart = x3c_vertexStart + (x2c_vertexCount * 12);

Runtime/CDvdFile.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "Runtime/CDvdFile.hpp"
22

3-
#include <optick.h>
3+
//#include <optick.h>
44

55
#include "Runtime/CDvdRequest.hpp"
66
#include "Runtime/CStopwatch.hpp"
@@ -154,7 +154,7 @@ void CDvdFile::DoWork() {
154154

155155
void CDvdFile::WorkerProc() {
156156
#ifdef HAS_DVD_THREAD
157-
OPTICK_THREAD("CDvdFile");
157+
//OPTICK_THREAD("CDvdFile");
158158

159159
while (m_WorkerRun.load()) {
160160
std::unique_lock lk{m_WorkerMutex};

Runtime/CFactoryMgr.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include <array>
55
#include <cctype>
66
#include <iterator>
7-
#include "optick.h"
7+
//#include "optick.h"
88

99
#include "Runtime/CStopwatch.hpp"
1010
#include "Runtime/IObj.hpp"
@@ -36,7 +36,7 @@ bool CFactoryMgr::CanMakeMemory(const metaforce::SObjectTag& tag) const {
3636
CFactoryFnReturn CFactoryMgr::MakeObjectFromMemory(const SObjectTag& tag, std::unique_ptr<u8[]>&& buf, int size,
3737
bool compressed, const CVParamTransfer& paramXfer,
3838
CObjectReference* selfRef) {
39-
OPTICK_EVENT();
39+
//OPTICK_EVENT();
4040
std::unique_ptr<u8[]> localBuf = std::move(buf);
4141

4242
const auto memFactoryIter = x24_memFactories.find(tag.type);

Runtime/CMain.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ struct Application {
270270
const auto targetFrameTime = getTargetFrameTime();
271271
bool skipRetrace = false;
272272
if (g_ResFactory != nullptr) {
273-
OPTICK_EVENT("Async Load Resources");
273+
// OPTICK_EVENT("Async Load Resources");
274274
const auto idleTime = m_limiter.SleepTime(targetFrameTime);
275275
skipRetrace = g_ResFactory->AsyncIdle(idleTime);
276276
}
@@ -281,12 +281,12 @@ struct Application {
281281
} else {
282282
// No more to load, and we're under frame time
283283
{
284-
OPTICK_EVENT("Sleep");
284+
//OPTICK_EVENT("Sleep");
285285
m_limiter.Sleep(targetFrameTime);
286286
}
287287
}
288288

289-
OPTICK_FRAME("MainThread");
289+
//OPTICK_FRAME("MainThread");
290290

291291
// Check if fullscreen has been toggled, if so set the fullscreen cvar accordingly
292292
if (m_fullscreenToggleRequested) {
@@ -350,7 +350,7 @@ struct Application {
350350
}
351351

352352
void onAppDraw() noexcept {
353-
OPTICK_EVENT("Draw");
353+
//OPTICK_EVENT("Draw");
354354
if (g_Renderer != nullptr) {
355355
g_Renderer->BeginScene();
356356
if (g_mainMP1) {
@@ -362,7 +362,7 @@ struct Application {
362362
}
363363

364364
void onAppPostDraw() noexcept {
365-
OPTICK_EVENT("PostDraw");
365+
//OPTICK_EVENT("PostDraw");
366366
// if (m_voiceEngine) {
367367
// m_voiceEngine->pumpAndMixVoices();
368368
// }

Runtime/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ function(add_runtime_common_library name)
149149
endfunction()
150150

151151
set(RUNTIME_INCLUDES ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_SOURCE_DIR})
152-
set(RUNTIME_LIBRARIES zeus nod NESEmulator libjpeg-turbo jbus kabufuda OptickCore
152+
set(RUNTIME_LIBRARIES zeus nod NESEmulator libjpeg-turbo jbus kabufuda #OptickCore
153153
imgui_support aurora::core aurora::gx aurora::pad aurora::si aurora::vi aurora::mtx spdlog::spdlog $<$<BOOL:${WIN32}>:nowide::nowide>
154154
${ZLIB_LIBRARIES}
155155
)

Runtime/CResFactory.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#include "Runtime/Logging.hpp"
66
#include "Runtime/Formatting.hpp"
77

8-
#include "optick.h"
8+
//#include "optick.h"
99

1010
namespace metaforce {
1111
void CResFactory::AddToLoadList(SLoadingData&& data) {
@@ -35,7 +35,7 @@ CFactoryFnReturn CResFactory::BuildSync(const SObjectTag& tag, const CVParamTran
3535
}
3636

3737
bool CResFactory::PumpResource(SLoadingData& data) {
38-
OPTICK_EVENT();
38+
//OPTICK_EVENT();
3939
if (data.x8_dvdReq && data.x8_dvdReq->IsComplete()) {
4040
data.x8_dvdReq.reset();
4141
*data.xc_targetPtr =
@@ -77,7 +77,7 @@ void CResFactory::BuildAsync(const SObjectTag& tag, const CVParamTransfer& xfer,
7777
}
7878

7979
bool CResFactory::AsyncIdle(std::chrono::nanoseconds target) {
80-
OPTICK_EVENT();
80+
//OPTICK_EVENT();
8181
if (m_loadList.empty()) {
8282
return false;
8383
}

Runtime/CStateManager.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,7 @@ void CStateManager::DrawWorld() {
776776
g_Renderer->SetThermalColdScale(xf28_thermColdScale2 + xf24_thermColdScale1);
777777

778778
for (int i = areaCount - 1; i >= 0; --i) {
779-
OPTICK_EVENT("CStateManager::DrawWorld DrawArea");
779+
//OPTICK_EVENT("CStateManager::DrawWorld DrawArea");
780780
const CGameArea& area = *areaArr[i];
781781
SetupFogForArea(area);
782782
g_Renderer->EnablePVS(pvsArr[i], area.x4_selfIdx);
@@ -1375,7 +1375,7 @@ void CStateManager::LoadScriptObjects(TAreaId aid, CInputStream& in, std::vector
13751375

13761376
std::pair<TEditorId, TUniqueId> CStateManager::LoadScriptObject(TAreaId aid, EScriptObjectType type, u32 length,
13771377
CInputStream& in) {
1378-
OPTICK_EVENT();
1378+
//OPTICK_EVENT();
13791379
const TEditorId id = in.ReadLong();
13801380
const u32 connCount = in.ReadLong();
13811381
length -= 8;

Runtime/Character/CAnimData.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ void CAnimData::Render(CSkinnedModel& model, const CModelFlags& drawFlags, CVert
551551
}
552552

553553
void CAnimData::SetupRender(CSkinnedModel& model, CVertexMorphEffect* morphEffect, TConstVectorRef averagedNormals) {
554-
OPTICK_EVENT();
554+
//OPTICK_EVENT();
555555
if (!x220_30_poseBuilt) {
556556
x2fc_poseBuilder.BuildNoScale(x224_pose);
557557
x220_30_poseBuilt = true;

Runtime/Graphics/CGraphics.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ float CGraphics::GetSecondsMod900() {
653653
}
654654

655655
void CGraphics::TickRenderTimings() {
656-
OPTICK_EVENT();
656+
//OPTICK_EVENT();
657657
mRenderTimings = (mRenderTimings + 1) % (900 * 60);
658658
mSecondsMod900 = static_cast<float>(mRenderTimings) / 60.f;
659659
}

0 commit comments

Comments
 (0)