diff --git a/README.md b/README.md index 8d364b3..9c3386b 100644 --- a/README.md +++ b/README.md @@ -8,9 +8,9 @@ The *Signed Video Framework* is an open-source project that secures an H264, or ## Getting started with the repo This repository contains a set of application examples which aims to enrich the developers implementation experience. All examples are using the [signed-video-framework](https://github.com/AxisCommunications/signed-video-framework) and has a README file in its directory with instructions on how to build and run it. -The repository uses meson + ninja as default build method. Further, all application examples uses gStreamer APIs. +The repository uses meson + ninja as default build method. Further, all application examples uses GStreamer APIs. - [meson](https://mesonbuild.com/Getting-meson.html) Getting meson and ninja. Meson version 0.49.0 or newer is required. -- [gStreamer](https://gstreamer.freedesktop.org/documentation/installing/index.html?gi-language=c) All applications are built around the gStreamer framework to handle coded video. +- [GStreamer](https://gstreamer.freedesktop.org/documentation/installing/index.html?gi-language=c) All applications are built around the GStreamer framework to handle coded video. ## Example applications Below is a list of example applications available in the repository. diff --git a/apps/signer/README.md b/apps/signer/README.md index d3657d5..bc6cf18 100644 --- a/apps/signer/README.md +++ b/apps/signer/README.md @@ -5,15 +5,15 @@ Note: This example application code also serves as example code for how to imple *Signed Video Framework*. ## Prerequisites -This application relies on gStreamer and signed-video-framework. -- [gStreamer](https://gstreamer.freedesktop.org/documentation/installing/index.html?gi-language=c) +This application relies on GStreamer and signed-video-framework. +- [GStreamer](https://gstreamer.freedesktop.org/documentation/installing/index.html?gi-language=c) - [signed-video-framework](https://github.com/AxisCommunications/signed-video-framework) ## Description The application processes a file NALU by NALU and adds signatures in SEIs, provided by the *Signed Video Framework*. A successfully signed GOP prints it on the screen. -It is implemented as a gStreamer element that process every NALU and adds SEI NALs to the stream repeatedly. +It is implemented as a GStreamer element that process every NALU and adds SEI NALs to the stream repeatedly. The signed video is written to a new file, prepending the filenamne with `signed_`. That is, `test_h264.mp4` becomes `signed_test_h264.mp4`. The application requires the file to process to be in the current directory. ## Building the signer application @@ -33,7 +33,7 @@ Build and install the library locally in `./my_installs/`. meson --prefix $PWD/my_installs signed-video-framework build_lib meson install -C build_lib ``` -Then build and install the `signer` in the same place. Since this application is implemented as a gStreamer element set `GST_PLUGIN_PATH` for gStreamer to find it. +Then build and install the `signer` in the same place. Since this application is implemented as a GStreamer element set `GST_PLUGIN_PATH` for GStreamer to find it. ``` export GST_PLUGIN_PATH=$PWD/my_installs meson --prefix $PWD/my_installs -Dsigner=true signed-video-framework-examples build_apps diff --git a/apps/signer/main.c b/apps/signer/main.c index 3a219b7..8b1b64c 100644 --- a/apps/signer/main.c +++ b/apps/signer/main.c @@ -227,11 +227,11 @@ main(gint argc, gchar *argv[]) filesink = gst_element_factory_make("filesink", NULL); if (!filesrc || !demuxer || !parser || !muxer || !filesink) { - if (!filesrc) g_message("gStreamer element 'filesrc' not found"); - if (!demuxer) g_message("gStreamer element '%s' not found", demux_str); - if (!parser) g_message("gStreamer element '%sparse' not found", codec_str); - if (!muxer) g_message("gStreamer element '%s' not found", mux_str); - if (!filesink) g_message("gStreamer element 'filesink' not found"); + if (!filesrc) g_message("GStreamer element 'filesrc' not found"); + if (!demuxer) g_message("GStreamer element '%s' not found", demux_str); + if (!parser) g_message("GStreamer element '%sparse' not found", codec_str); + if (!muxer) g_message("GStreamer element '%s' not found", mux_str); + if (!filesink) g_message("GStreamer element 'filesink' not found"); goto out; } else if (!signedvideo) { diff --git a/apps/validator/README.md b/apps/validator/README.md index 0661e92..7e787a4 100644 --- a/apps/validator/README.md +++ b/apps/validator/README.md @@ -5,8 +5,8 @@ Note: This example application code also serves as example code for how to imple the *Signed Video Framework*. ## Prerequisites -This application relies on GstAppSink (part of gStreamer) and signed-video-framework. -- [gStreamer](https://gstreamer.freedesktop.org/documentation/installing/index.html?gi-language=c) +This application relies on GstAppSink (part of GStreamer) and signed-video-framework. +- [GStreamer](https://gstreamer.freedesktop.org/documentation/installing/index.html?gi-language=c) - [signed-video-framework](https://github.com/AxisCommunications/signed-video-framework) ## Description diff --git a/apps/validator/main.c b/apps/validator/main.c index c3017b2..714f346 100644 --- a/apps/validator/main.c +++ b/apps/validator/main.c @@ -166,7 +166,7 @@ is_signed_video_sei(const guint8 *nalu, SignedVideoCodec codec) idx++; } else { // Start code NOT present. Assume the first 4 bytes have been replaced with size, - // which is common in, e.g., gStreamer. + // which is common in, e.g., GStreamer. idx = 4; } diff --git a/meson.build b/meson.build index 20217db..01e79ab 100644 --- a/meson.build +++ b/meson.build @@ -23,7 +23,7 @@ signedvideoframework_dep = declare_dependency( include_directories : include_directories(sv_header_dir), ) -# gStreamer is used by all applications +# GStreamer is used by all applications gst_req = '>= 1.0.0' api_version = '1.0' gst_dep = dependency(