libsoup abstraction library details

[ys5g]

Is your feature request related to a problem? Please describe.
This is not related to a bug. I started implementing a libsoup abstraction library a while ago but had a few questions:

1. In CONTRIBUTING.md, it says that it is "mostly to be used in gjs and lua." Does this mean it should be implemented in ts and lua in lang/? This lib would make HTTP requests in vala easier so that would seem like a waste
2. What libsoup version should be used(2.4 or 3)?
3. If we're taking the vala approach, is it fine if a headers parameter takes a GLib.HashTable obj? I'm asking since no one has ever used a Glib.HashTable in gjs (except 1 person on github 💀).

[kotontrion]

1. Implementing it in vala is fine, just design the lib with gjs and lua in mind and make sure it works well in those languages.
2. use libsoup 3
3. gjs can convert js objects to Glib.HashTable, so that's fine. Not sure about lua though.

[ys5g]

gjs can convert js objects to Glib.HashTable, so that's fine

I am definitely doing something wrong, but passing a TS Map to a function that expects a GLib.HashTable doesn't seem to work(link to branch):

Btw, if you're reading this over 30 minutes after I posted this comment, you'll get the error "invalid token," which isn't a problem(in this case) since the headers are getting passed to libsoup.

Code

#!/usr/bin/env -S ags run --gtk4
import { exec } from "astal"
import { App, Astal, Gdk, Widget } from "astal/gtk4"
import { GLib } from "astal/gobject"
import Soup from "gi://Soup"
import Http from "gi://AstalHttp"
App.start({
  instanceName: "qishr",
  main: () => {
    const url = "https://dummyjson.com/auth/me";
    const bearer = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwidXNlcm5hbW" +
      "UiOiJlbWlseXMiLCJlbWFpbCI6ImVtaWx5LmpvaG5zb25AeC5kdW1teWpzb24uY29tIiwiZm" +
      "lyc3ROYW1lIjoiRW1pbHkiLCJsYXN0TmFtZSI6IkpvaG5zb24iLCJnZW5kZXIiOiJmZW1hbG" +
      "UiLCJpbWFnZSI6Imh0dHBzOi8vZHVtbXlqc29uLmNvbS9pY29uL2VtaWx5cy8xMjgiLCJpYX" +
      "QiOjE3MzYyODI2MzAsImV4cCI6MTczNjI4NDQzMH0.LySRSrg5fIjqZlUJFHdYExigJfiSlVAHO6kH2xNkAbU";
    const headers = new Map([
      ["Authorization", `Bearer ${bearer}`],
    ]);
    const { TOP, LEFT, RIGHT } = Astal.WindowAnchor;
    new Astal.Window({
      name: "bar",
      anchor: TOP | LEFT | RIGHT,
      application: App,
      exclusivity: Astal.Exclusivity.EXCLUSIVE,
      visible: true,
      
      child: Widget.CenterBox({
        startWidget: Widget.Button({
          label: "Use the abstraction library",
          onClicked: () => {
            print(
              Http.Request.get(url, headers).call()
            )
          }
        }),
        endWidget: Widget.Button({
          label: "Use libsoup directly",
          onClicked: () => {
            const sess = new Soup.Session();
            const msg = new Soup.Message({
              method: "GET",
              uri: GLib.Uri.parse(url, GLib.UriFlags.NONE)
            });

            headers.forEach((value, key) => {
              msg.request_headers.append(key, value)
            });

            const respBytes = sess.send_and_read(msg, null);
            var resp = new TextDecoder().decode(respBytes)

            print(resp);
          }
        })
      })
    })
  }
})

[kotontrion]

gjs can convert js objects to Glib.HashTable

I meant plain js objects here. So this should work:

const headers = {
    "Authorization": `Bearer ${bearer}`
}
Http.Request.get(url, headers).call()