unroll always

Author: sirasistant

noir-projects/noir-protocol-circuits/crates/blob/src/abis/blob_accumulator.nr

@@ -186,6 +186,7 @@ impl Serialize for BlobAccumulator {
         writer.finish()
     }
 
+    #[inline_always]
     fn stream_serialize<let K: u32>(self, writer: &mut Writer<K>) {
         writer.write(self.blob_commitments_hash_acc);
         writer.write(self.z_acc);
@@ -210,6 +211,7 @@ impl Deserialize for BlobAccumulator {
         result
     }
 
+    #[inline_always]
     fn stream_deserialize<let K: u32>(reader: &mut Reader<K>) -> Self {
         Self {
             blob_commitments_hash_acc: reader.read(),

noir-projects/noir-protocol-circuits/crates/blob/src/abis/final_blob_batching_challenges.nr

@@ -46,6 +46,7 @@ impl Serialize for FinalBlobBatchingChallenges {
         writer.finish()
     }
 
+    #[inline_always]
     fn stream_serialize<let K: u32>(self, writer: &mut Writer<K>) {
         writer.write(self.z);
         writer.write_array(self.gamma.get_limbs().map(|l| l as Field));
@@ -62,6 +63,7 @@ impl Deserialize for FinalBlobBatchingChallenges {
         result
     }
 
+    #[inline_always]
     fn stream_deserialize<let K: u32>(reader: &mut Reader<K>) -> Self {
         Self {
             z: reader.read(),

noir-projects/noir-protocol-circuits/crates/serde/src/type_impls.nr

@@ -487,6 +487,7 @@ impl Serialize for EmbeddedCurveScalar {
         [self.lo, self.hi]
     }
 
+    #[inline_always]
     fn stream_serialize<let K: u32>(self, writer: &mut Writer<K>) {
         writer.write(self.lo);
         writer.write(self.hi);
@@ -500,6 +501,7 @@ impl Deserialize for EmbeddedCurveScalar {
         Self { lo: fields[0], hi: fields[1] }
     }
 
+    #[inline_always]
     fn stream_deserialize<let K: u32>(reader: &mut Reader<K>) -> Self {
         Self { lo: reader.read(), hi: reader.read() }
     }
@@ -528,6 +530,7 @@ impl Deserialize for EmbeddedCurvePoint {
         Self { x: fields[0], y: fields[1], is_infinite: fields[2] != 0 }
     }
 
+    #[inline_always]
     fn stream_deserialize<let K: u32>(reader: &mut Reader<K>) -> Self {
         Self { x: reader.read(), y: reader.read(), is_infinite: reader.read_bool() }
     }
@@ -615,6 +618,7 @@ impl Deserialize for () {
         result
     }
 
+    #[inline_always]
     fn stream_deserialize<let K: u32>(_reader: &mut Reader<K>) -> Self {
         ()
     }
@@ -719,7 +723,7 @@ comptime fn impl_serialize_for_tuple(_m: Module, length: u32) -> Quoted {
                 writer.finish()
             }
 
-
+            #[inline_always]
             fn stream_serialize<let K: u32>(self, writer: &mut $crate::writer::Writer<K>) {
 
                 $serialized_fields
@@ -735,8 +739,8 @@ comptime fn impl_serialize_for_tuple(_m: Module, length: u32) -> Quoted {
                 reader.finish();
                 result
             }
-
-
+    
+            #[inline_always]
             fn stream_deserialize<let K: u32>(reader: &mut $crate::reader::Reader<K>) -> Self {
                 $deserialized_fields
                 ($deserialize_results)
@@ -759,6 +763,7 @@ where
         writer.finish()
     }
 
+    #[inline_always]
     fn stream_serialize<let K: u32>(self, writer: &mut Writer<K>) {
         self.0.stream_serialize(writer);
     }
@@ -777,6 +782,7 @@ where
         result
     }
 
+    #[inline_always]
     fn stream_deserialize<let K: u32>(reader: &mut Reader<K>) -> Self {
         (<T1 as Deserialize>::stream_deserialize(reader),)
     }

noir-projects/noir-protocol-circuits/crates/types/src/meta/mod.nr

@@ -322,15 +322,6 @@ mod test {
         pub length: u32,
     }
 
-    #[test]
-    fn serde_on_empty() {
-        let original = Empty {};
-        let serialized = original.serialize();
-        assert_eq(serialized, [], "Serialized does not match empty array");
-        let deserialized = Empty::deserialize(serialized);
-        assert_eq(deserialized, original, "Deserialized does not match original");
-    }
-
     #[test]
     fn packable_on_empty() {
         let original = Empty {};
@@ -341,53 +332,16 @@ mod test {
     }
 
     #[test]
-    fn serde_on_smol() {
+    fn packable_on_smol() {
         let smol = Smol { a: 1, b: 2 };
         let serialized = smol.serialize();
         assert(serialized == [1, 2], serialized);
-        let deserialized = Smol::deserialize(serialized);
-        assert(deserialized == smol);
 
         // None of the struct members implements the `Packable` trait so the packed and serialized data should be the same
         let packed = smol.pack();
         assert_eq(packed, serialized, "Packed does not match serialized");
     }
 
-    #[test]
-    fn serde_on_has_array() {
-        let has_array = HasArray { a: [1, 2], b: true };
-        let serialized = has_array.serialize();
-        assert(serialized == [1, 2, 1], serialized);
-        let deserialized = HasArray::deserialize(serialized);
-        assert(deserialized == has_array);
-    }
-
-    #[test]
-    fn serde_on_fancier() {
-        let fancier =
-            Fancier { a: Smol { a: 1, b: 2 }, b: [0, 1], c: [1, 2, 3], d: "metaprogramming!" };
-        let serialized = fancier.serialize();
-        assert(
-            serialized
-                == [
-                    1, 2, 0, 1, 1, 2, 3, 0x6d, 0x65, 0x74, 0x61, 0x70, 0x72, 0x6f, 0x67, 0x72, 0x61,
-                    0x6d, 0x6d, 0x69, 0x6e, 0x67, 0x21,
-                ],
-            serialized,
-        );
-        let deserialized = Fancier::deserialize(serialized);
-        assert(deserialized == fancier);
-    }
-
-    #[test]
-    fn serde_on_contains_array_with_generics() {
-        let struct_with_array_of_generics = HasArrayWithGenerics { fields: [1, 2, 3], length: 3 };
-        let serialized = struct_with_array_of_generics.serialize();
-        assert(serialized == [1, 2, 3, 3], serialized);
-        let deserialized = HasArrayWithGenerics::deserialize(serialized);
-        assert(deserialized == struct_with_array_of_generics);
-    }
-
     #[test]
     fn packable_on_contains_array_with_generics() {
         let struct_with_array_of_generics = HasArrayWithGenerics { fields: [1, 2, 3], length: 3 };