comp fixes

Author: benesjan

noir-projects/aztec-nr/aztec/src/context/private_context.nr

@@ -929,9 +929,10 @@ impl PrivateContext {
         let log_to_emit: [Field; CONTRACT_CLASS_LOG_SIZE_IN_FIELDS] =
             log.concat([0; CONTRACT_CLASS_LOG_SIZE_IN_FIELDS - N]);
         // Note: the length is not always N, it is the number of fields we want to broadcast, omitting trailing zeros
-        // to save blob space. Safety: The below length is constrained in the base rollup, which will make sure that
-        // all the fields beyond length are zero. However, it won't be able to check that we didn't add extra padding
-        // (trailing zeroes) or that we cut trailing zeroes from the end.
+        // to save blob space.
+        // Safety: The below length is constrained in the base rollup, which will make sure that all the fields beyond
+        // length are zero. However, it won't be able to check that we didn't add extra padding (trailing zeroes) or
+        // that we cut trailing zeroes from the end.
         let length = unsafe { trimmed_array_length_hint(log_to_emit) };
         // We hash the entire padded log to ensure a user cannot pass a shorter length and so emit incorrect shorter
         // bytecode.

noir-projects/aztec-nr/aztec/src/context/public_context.nr

@@ -436,8 +436,8 @@ impl PublicContext {
     /// * Used internally for function dispatch in the AVM
     ///
     pub fn selector(_self: Self) -> FunctionSelector {
-        // The selector is the first element of the calldata when calling a public function through dispatch. Safety:
-        // AVM opcodes are constrained by the AVM itself
+        // The selector is the first element of the calldata when calling a public function through dispatch.
+        // Safety: AVM opcodes are constrained by the AVM itself.
         let raw_selector: [Field; 1] = unsafe { avm::calldata_copy(0, 1) };
         FunctionSelector::from_field(raw_selector[0])
     }

noir-projects/aztec-nr/aztec/src/history/nullifier.nr

@@ -33,8 +33,8 @@ mod test;
 /// is typically cheaper. Note that there are semantic differences though, as that function also considers _pending_
 /// nullifiers.
 pub fn assert_nullifier_existed_by(block_header: BlockHeader, siloed_nullifier: Field) {
-    // 1) Get the membership witness of the nullifier Safety: The witness is only used as a "magical value" that makes
-    // the proof below pass. Hence it's safe.
+    // 1) Get the membership witness of the nullifier.
+    // Safety: The witness is only used as a "magical value" that makes the proof below pass. Hence it's safe.
     let witness = unsafe { get_nullifier_membership_witness(block_header, siloed_nullifier) };
 
     // 2) First we prove that the tree leaf in the witness is present in the nullifier tree. This is expected to be the
@@ -84,8 +84,8 @@ pub fn assert_nullifier_existed_by(block_header: BlockHeader, siloed_nullifier:
 ///
 /// This function performs a full merkle tree inclusion proof, which is in the order of 4k gates.
 pub fn assert_nullifier_did_not_exist_by(block_header: BlockHeader, siloed_nullifier: Field) {
-    // 1) Get the membership witness of a low nullifier of the nullifier Safety: The witness is only used as a "magical
-    // value" that makes the proof below pass. Hence it's safe.
+    // 1) Get the membership witness of a low nullifier of the nullifier.
+    // Safety: The witness is only used as a "magical value" that makes the proof below pass. Hence it's safe.
     let witness = unsafe { get_low_nullifier_membership_witness(block_header, siloed_nullifier) };
 
     // 2) Check that the leaf preimage is not empty. An empty leaf preimage would pass validation as a low leaf.

noir-projects/aztec-nr/aztec/src/history/storage.nr

@@ -21,8 +21,8 @@ pub fn public_storage_historical_read(
         DOM_SEP__PUBLIC_LEAF_INDEX,
     );
 
-    // 2) Get the membership witness for the tree index. Safety: The witness is only used as a "magical value" that
-    // makes the proof below pass. Hence it's safe.
+    // 2) Get the membership witness for the tree index.
+    // Safety: The witness is only used as a "magical value" that makes the proof below pass. Hence it's safe.
     let witness = unsafe { get_public_data_witness(block_header, public_data_tree_index) };
 
     public_data_storage_read(

noir-projects/aztec-nr/aztec/src/messaging.nr

@@ -27,8 +27,8 @@ pub fn process_l1_to_l2_message(
     );
 
     // We prove that `message_hash` is in the tree by showing the derivation of the tree root, using a merkle path we
-    // get from an oracle. Safety: The witness is only used as a "magical value" that makes the merkle proof below
-    // pass. Hence it's safe.
+    // get from an oracle.
+    // Safety: The witness is only used as a "magical value" that makes the merkle proof below pass. Hence it's safe.
     let (_leaf_index, sibling_path) =
         unsafe { get_l1_to_l2_membership_witness(contract_address, message_hash, secret) };
 

noir-projects/aztec-nr/aztec/src/oracle/block_header.nr

@@ -33,8 +33,8 @@ pub fn get_block_header_at(block_number: u32, context: PrivateContext) -> BlockH
             "Last archive block number is smaller than the block number we want to prove against",
         );
 
-        // 3) Get the header hint of a given block from an oracle Safety: The header is constrained to be in the
-        // archive tree below.
+        // 3) Get the header hint of a given block from an oracle.
+        // Safety: The header is constrained to be in the archive tree below.
         let header = unsafe { get_block_header_at_internal(block_number) };
 
         // 4) We make sure that the header hint we received from the oracle exists in the state tree and is the actual
@@ -54,8 +54,8 @@ fn constrain_get_block_header_at_internal(
     // 1) Compute the block hash from the block header
     let block_hash = header_hint.hash();
 
-    // 2) Get the membership witness of the block in the archive tree Safety: The witness is only used as a "magical
-    // value" that makes the merkle proof below pass. Hence it's safe.
+    // 2) Get the membership witness of the block in the archive tree.
+    // Safety: The witness is only used as a "magical value" that makes the merkle proof below pass. Hence it's safe.
     let witness = unsafe { get_archive_membership_witness(anchor_block_header, block_hash) };
 
     // 3) Check that the block is in the archive (i.e. the witness is valid)