chore: fixing noir warnings (#15856)

Fixing the vast majority of compiler warnings in `noir-projects`.

Tackling this now as incoming Noir release will disallow accessing of
private fields and private functionality.

These warnings are remaining:

<img width="1128" height="523" alt="image"
src="https://github.com/user-attachments/assets/a9372a2b-ce93-41f3-9a4b-ffa96b60ba5f"
/>

The first one is impractical to fix, the 2nd, 3rd and 4th I am not sure
how to fix and the last one I plan on making the AVM team fix.

---------

Co-authored-by: Nicolás Venturo <[email protected]>

Author: benesjan

noir-projects/aztec-nr/address-note/src/address_note.nr

@@ -22,5 +22,9 @@ impl AddressNote {
         let randomness = unsafe { random() };
         AddressNote { address, owner, randomness }
     }
+
+    pub fn get_address(self) -> AztecAddress {
+        self.address
+    }
 }
 // docs:end:address_note_def

noir-projects/aztec-nr/aztec/src/context/private_context.nr

@@ -550,7 +550,10 @@ impl PrivateContext {
         };
     }
 
-    fn next_counter(&mut self) -> u32 {
+    // This function got exposed publicly to be able to access it in ContractClassRegistry.
+    // TODO(#15980): Implement a method for pushing contract class log hashes to the context and un-expose this
+    // function.
+    pub fn next_counter(&mut self) -> u32 {
         let counter = self.side_effect_counter;
         self.side_effect_counter += 1;
         counter

noir-projects/aztec-nr/aztec/src/context/public_context.nr

@@ -321,7 +321,10 @@ unconstrained fn l1_to_l2_msg_exists(msg_hash: Field, msg_leaf_index: u64) -> u1
 unconstrained fn send_l2_to_l1_msg(recipient: EthAddress, content: Field) {
     send_l2_to_l1_msg_opcode(recipient, content)
 }
-unconstrained fn call(
+
+// This function is temporarily exposed publicly to be able to test it in AVMTest contract.
+// TODO(#15980): Refactor tests to keep this implementation detail private within the crate.
+pub unconstrained fn call(
     l2_gas_allocation: u32,
     da_gas_allocation: u32,
     address: AztecAddress,
@@ -344,15 +347,22 @@ pub unconstrained fn calldata_copy<let N: u32>(cdoffset: u32, copy_size: u32) ->
 }
 
 // `success_copy` is placed immediately after the CALL opcode to get the success value
-unconstrained fn success_copy() -> bool {
+//
+// This function is temporarily exposed publicly to be able to test it in AVMTest contract.
+// TODO: Refactor tests to keep this implementation detail private within the crate.
+pub unconstrained fn success_copy() -> bool {
     success_copy_opcode()
 }
 
-unconstrained fn returndata_size() -> u32 {
+// This function is temporarily exposed publicly to be able to test it in AVMTest contract.
+// TODO: Refactor tests to keep this implementation detail private within the crate.
+pub unconstrained fn returndata_size() -> u32 {
     returndata_size_opcode()
 }
 
-unconstrained fn returndata_copy(rdoffset: u32, copy_size: u32) -> [Field] {
+// This function is temporarily exposed publicly to be able to test it in AVMTest contract.
+// TODO: Refactor tests to keep this implementation detail private within the crate.
+pub unconstrained fn returndata_copy(rdoffset: u32, copy_size: u32) -> [Field] {
     returndata_copy_opcode(rdoffset, copy_size)
 }
 
@@ -364,7 +374,10 @@ pub unconstrained fn avm_return(returndata: [Field]) {
 // to do rethrows, where the revert data is the same as the original revert data.
 // For normal reverts, use Noir's `assert` which, on top of reverting, will also add
 // an error selector to the revert data.
-unconstrained fn avm_revert(revertdata: [Field]) {
+//
+// This function is temporarily exposed publicly to be able to test it in AVMTest contract.
+// TODO: Refactor tests to keep this implementation detail private within the crate.
+pub unconstrained fn avm_revert(revertdata: [Field]) {
     revert_opcode(revertdata)
 }
 

noir-projects/aztec-nr/aztec/src/macros/functions/mod.nr

@@ -1,6 +1,8 @@
 pub(crate) mod abi_export;
 pub(crate) mod call_interface_stubs;
-pub(crate) mod initialization_utils;
+// TODO: Move initialization_utils out of this crate
+// See https://github.com/AztecProtocol/aztec-packages/pull/15856#discussion_r2229134689 for more details
+pub mod initialization_utils;
 pub(crate) mod stub_registry;
 pub(crate) mod auth_registry;
 pub(crate) mod utils;

noir-projects/aztec-nr/aztec/src/note/note_emission.nr

@@ -29,7 +29,7 @@ impl<Note> NoteEmission<Note> {
  * a change note in a token's transfer function only when there is "change" left).
  */
 pub struct OuterNoteEmission<Note> {
-    emission: Option<NoteEmission<Note>>,
+    pub emission: Option<NoteEmission<Note>>,
 }
 
 impl<Note> OuterNoteEmission<Note> {

noir-projects/aztec-nr/aztec/src/test/mocks/mod.nr

@@ -1,2 +1,2 @@
-pub(crate) mod mock_note;
-pub(crate) mod mock_struct;
+pub mod mock_note;
+pub mod mock_struct;

noir-projects/aztec-nr/aztec/src/test/mod.nr

@@ -1,2 +1,2 @@
 pub mod helpers;
-pub(crate) mod mocks;
+pub mod mocks;

noir-projects/aztec-nr/easy-private-state/src/easy_private_uint.nr

@@ -1,11 +1,11 @@
 use dep::aztec::{
-    context::PrivateContext,
+    context::{PrivateContext, UtilityContext},
     messages::logs::note::encode_and_encrypt_note,
     note::note_getter_options::NoteGetterOptions,
     protocol_types::address::AztecAddress,
     state_vars::{PrivateSet, storage::HasStorageSlot},
 };
-use dep::value_note::{filter::filter_notes_min_sum, value_note::ValueNote};
+use dep::value_note::{balance_utils, filter::filter_notes_min_sum, value_note::ValueNote};
 
 pub struct EasyPrivateUint<Context> {
     context: Context,
@@ -61,3 +61,9 @@ impl EasyPrivateUint<&mut PrivateContext> {
         self.set.insert(result_note).emit(encode_and_encrypt_note(self.context, owner));
     }
 }
+
+impl EasyPrivateUint<UtilityContext> {
+    pub unconstrained fn get_value(self) -> Field {
+        balance_utils::get_balance(self.set)
+    }
+}

noir-projects/aztec-nr/uint-note/src/uint_note.nr

@@ -104,6 +104,10 @@ impl UintNote {
         self.value
     }
 
+    pub fn get_owner(self) -> AztecAddress {
+        self.owner
+    }
+
     /// Creates a partial note that will hide the owner and storage slot but not the value, since the note will be later
     /// completed in public. This is a powerful technique for scenarios in which the value cannot be known in private
     /// (e.g. because it depends on some public state, such as a DEX).
@@ -329,7 +333,7 @@ mod test {
     };
     use dep::aztec::{
         note::note_interface::NoteHash,
-        protocol_types::{address::AztecAddress, traits::{FromField, Packable}},
+        protocol_types::{address::AztecAddress, traits::{Deserialize, FromField, Packable}},
         utils::array::subarray,
     };
 
@@ -373,7 +377,9 @@ mod test {
             randomness,
             public_log_tag: commitment,
         };
-        let partial_note = PartialUintNote { commitment };
+        // The following is a misuse of the `deserialize` function, but this is just a test and it's better than
+        // letting devs manually construct it when they shouldn't be able to.
+        let partial_note = PartialUintNote::deserialize([commitment]);
 
         // The first field of the partial note private content is the public completion log tag, so it should match the
         // first field of the public log.

noir-projects/aztec-nr/value-note/src/lib.nr

@@ -1,4 +1,4 @@
-mod balance_utils;
+pub mod balance_utils;
 mod filter;
 mod utils;
 mod value_note;