Skip to content

Commit ca42322

Browse files
benesjanspypsyPhilWindle
authored and
AztecBot
committed
feat: GrumpkinScalar type (#1919)
Fixes #1912 **Note 1**: I removed the Signer interface as the difference in private key types between `Grumpkin` and `secp256k1` made it impractical. Now we have a special type only for the "`Grumpkin` key" and the `secp256k1` key is represented as either as a `Buffer` or as `0x${string}` (in case of publisher private key). **Note 2**: I changed some of the hardcoded private keys because they didn't fit to `GrumpkinScalar` and auto-reduction is no longer allowed. **Note 3**: The way we get Grumpkin private key from mnemonic is insecure so I've created [this issue](AztecProtocol/aztec-packages#2052) for it. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: spypsy <[email protected]> Co-authored-by: PhilWindle <[email protected]>
1 parent 4c456a2 commit ca42322

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

cpp/src/barretenberg/common/serialize.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ __extension__ using uint128_t = unsigned __int128;
5151
// NOLINTBEGIN(cppcoreguidelines-pro-type-reinterpret-cast, cert-dcl58-cpp)
5252
// clang-format on
5353

54-
template <typename T>
55-
concept IntegralOrEnum = std::integral<T> || std::is_enum_v<T>;
54+
template <typename T> concept IntegralOrEnum = std::integral<T> || std::is_enum_v<T>;
5655

5756
namespace serialize {
5857
// Forward declare derived msgpack methods

0 commit comments

Comments
 (0)