Skip to content

Commit c96e554

Browse files
committed
Re-add and deprecate old kubejs casing event methods
1 parent 81cbdfb commit c96e554

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

docs/ADDING_MACHINES.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,10 +329,10 @@ For example:
329329
MIMachineEvents.registerCasings(event => {
330330
// Register a casing.
331331
// This doesn't register any model! Either add models or add the top/side/bottom textures.
332-
event.register("fancy_casing", "Fancy");
332+
event.registerNamed("fancy_casing", "Fancy");
333333

334334
// This registers a new casing with the same model as a diamond block!
335-
event.registerBlockImitation("diamond_casing", "Diamond", "minecraft:diamond_block");
335+
event.registerNamedBlockImitation("diamond_casing", "Diamond", "minecraft:diamond_block");
336336
})
337337
```
338338

src/main/java/aztech/modern_industrialization/compat/kubejs/machine/RegisterCasingsEventJS.java

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,36 @@
2323
*/
2424
package aztech.modern_industrialization.compat.kubejs.machine;
2525

26+
import aztech.modern_industrialization.MI;
2627
import aztech.modern_industrialization.datagen.model.MachineCasingImitations;
2728
import aztech.modern_industrialization.machines.models.MachineCasings;
2829
import dev.latvian.mods.kubejs.event.KubeEvent;
2930
import java.util.Objects;
3031
import net.minecraft.resources.ResourceLocation;
3132

3233
public class RegisterCasingsEventJS implements KubeEvent {
33-
public void register(String name, String englishName) {
34+
@Deprecated
35+
public void register(String... names) {
36+
MI.LOGGER.warn("register is deprecated, use registerNamed instead");
37+
for (var name : names) {
38+
registerNamed(name, null);
39+
}
40+
}
41+
42+
public void registerNamed(String name, String englishName) {
3443
if (name.contains(":")) {
3544
throw new IllegalArgumentException("Casing name cannot contain ':'.");
3645
}
3746
MachineCasings.create(name, englishName);
3847
}
3948

40-
public void registerBlockImitation(String name, String englishName, ResourceLocation block) {
49+
@Deprecated
50+
public void registerBlockImitation(String name, ResourceLocation block) {
51+
MI.LOGGER.warn("registerBlockImitation is deprecated, use registerNamedBlockImitation instead");
52+
registerNamedBlockImitation(name, null, block);
53+
}
54+
55+
public void registerNamedBlockImitation(String name, String englishName, ResourceLocation block) {
4156
Objects.requireNonNull(block, "block may not be null");
4257
if (name.contains(":")) {
4358
throw new IllegalArgumentException("Casing name cannot contain ':'.");

0 commit comments

Comments
 (0)