-
Notifications
You must be signed in to change notification settings - Fork 95
Various internal machine api improvements #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Oct 2, 2024
Swedz
added a commit
to Swedz/Modern-Industrialization
that referenced
this pull request
Nov 21, 2024
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves model API to allow so it is more extensible(moved to Make machine casings use ResourceLocations and translations #945)Use(moved to Make machine casings use ResourceLocations and translations #945)ResourceLocationfor machine casing ids. If no namespace is provided, it defaults to MI's namespaceWiden visibility and overridability of some methods and variables in(moved to Make machine shape matcher api more extensible #937),ShapeMatcher(moved to Make CableTier more accessible #939), andCasingComponent(moved to Make machine shape matcher api more extensible #937)MultiblockMachineBlockEntityMake the(moved to Make CableTier more accessible #939)CableTierofEnergyHatchandCasingComponentaccessibleImproves shape matcher API to allow for machines to define their own custom shape matcher and also standardizes the various methods triggered relating to multiblock shape matching (lots of duplicate code is removed)(moved to Make machine shape matcher api more extensible #937)Improve the internal storing of components such that they can be accessed and modified in the same way for both and includes some extra utility methods (I think I covered all reasonable use cases)(moved to Make machine component api more consistent and accessible #938)Allow for vertical orientations in(moved to Allow vertical orientations with component #940)OrientationComponentAllow(moved to Let BackgroundRenderedSlots override the background atlas #941)BackgroundRenderedSlotto override the atlas used to render them