Skip to content

Conversation

@Swedz
Copy link
Collaborator

@Swedz Swedz commented Oct 27, 2024

CustomProcessCondition#makeCodec(boolean) has no uses and could be removed - I'm not sure of what its purpose may have been so I haven't removed it quite yet.

Also, ViewerCategory$WidgetList#item(double, double, double, double, ItemLike) no longer has any uses due to my use of widgets.drawable(...) in MachineCategory. This could also be removed, but I want to make sure before doing it.

Swedz and others added 4 commits October 27, 2024 03:01
# Conflicts:
#	src/client/java/aztech/modern_industrialization/compat/viewer/usage/MachineCategory.java
#	src/main/java/aztech/modern_industrialization/machines/recipe/condition/BiomeProcessCondition.java
@Technici4n
Copy link
Contributor

Nice! I removed both makeCodec and WidgetList#item. The latter was written before GuiGraphics, when item rendering was messy and best left to each recipe viewer.

@Technici4n Technici4n enabled auto-merge (squash) January 2, 2025 10:00
@Technici4n Technici4n merged commit f6bc8f6 into AztechMC:1.21.x Jan 2, 2025
1 check passed
@Swedz Swedz deleted the recipe-condition-icons branch January 2, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants