-
Notifications
You must be signed in to change notification settings - Fork 95
Make CableTier more accessible #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What is the motivation behind these changes? I.e. how are they helpful? |
|
I use it quite a bit for my tesla coil machines I've been working on for EI. It lets me make an anonymous instance of CasingComponent to track when the casing changes and do some updates to the network when that happens. Plus, it makes grabbing the cable tier of a tesla coil block/multiblock much more straightforward (I was previously using a mixin to do this) - and I need that to be able to wirelessly transfer power on a specific voltage. |
It would be cleaner to add an optional change notification callback IMO. |
src/main/java/aztech/modern_industrialization/machines/components/CasingComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/aztech/modern_industrialization/machines/components/CasingComponent.java
Outdated
Show resolved
Hide resolved
|
I made those changes. I didn't add CableTierHolder to |
Contains some parts of #900
It might make sense to also add the
CableTierHolderinterface to electric machines and get the tier from their casing component. That can easily be done. Doing it for multi blocks is a little ambiguous since a multi block electric machine can have multiple types of hatches on it. It could just use the highest tier, though. Would either of these changes be acceptable?