Skip to content

Commit a2a03cd

Browse files
authored
Raise minimum node version (#2519)
* Raise minimum node version * Add Node version to test name
1 parent 355b2f1 commit a2a03cd

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

.devcontainer/devcontainer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"features": {
55
"ghcr.io/devcontainers/features/node:1": {
66
// This should match the version of Node.js in Github Actions workflows
7-
"version": "18",
7+
"version": "22",
88
"nodeGypDependencies": false
99
},
1010
"ghcr.io/devcontainers/features/azure-cli:1.2.5": {},

.github/workflows/python-test.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,14 @@ on:
1919

2020
jobs:
2121
test_package:
22-
name: Test ${{ matrix.os }} Python ${{ matrix.python_version }}
22+
name: Test ${{ matrix.os }} Python ${{ matrix.python_version }} Node ${{ matrix.node_version }}
2323
runs-on: ${{ matrix.os }}
2424
strategy:
2525
fail-fast: false
2626
matrix:
2727
os: ["ubuntu-latest", "windows-latest"]
2828
python_version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
29+
node_version: ["20", "22"]
2930
steps:
3031
- uses: actions/checkout@v4
3132
- name: Install uv
@@ -38,7 +39,7 @@ jobs:
3839
- name: Setup node
3940
uses: actions/setup-node@v4
4041
with:
41-
node-version: 18
42+
node-version: ${{ matrix.node_version }}
4243
- name: Build frontend
4344
run: |
4445
cd ./app/frontend

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ A related option is VS Code Dev Containers, which will open the project in your
134134
- [Python 3.9, 3.10, or 3.11](https://www.python.org/downloads/)
135135
- **Important**: Python and the pip package manager must be in the path in Windows for the setup scripts to work.
136136
- **Important**: Ensure you can run `python --version` from console. On Ubuntu, you might need to run `sudo apt install python-is-python3` to link `python` to `python3`.
137-
- [Node.js 18+](https://nodejs.org/download/)
137+
- [Node.js 20+](https://nodejs.org/download/)
138138
- [Git](https://git-scm.com/downloads)
139139
- [Powershell 7+ (pwsh)](https://github.com/powershell/powershell) - For Windows users only.
140140
- **Important**: Ensure you can run `pwsh.exe` from a PowerShell terminal. If this fails, you likely need to upgrade PowerShell.

app/frontend/.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
16.0.0
1+
22.0.0

app/frontend/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "0.0.0",
55
"type": "module",
66
"engines": {
7-
"node": ">=14.0.0"
7+
"node": ">=20.0.0"
88
},
99
"scripts": {
1010
"dev": "vite --host 127.0.0.1",

0 commit comments

Comments
 (0)