fix: extract hosted response enum roles

Author: Cataldir

lib/src/holiday_peak_lib/agents/hosted.py

@@ -118,7 +118,8 @@ def run(
         managed by the host server, and we do not yet pass extra client
         kwargs through to ``handle()``.
         """
-        _ = session, kwargs
+        messages = _resolve_run_messages(messages, kwargs)
+        _ = session
         if stream:
             return self._run_streaming(messages)
         return self._run_once(messages)
@@ -185,12 +186,27 @@ def _extract_user_text(messages: Any) -> str:
     return ""
 
 
+def _resolve_run_messages(messages: Any, kwargs: dict[str, Any]) -> Any:
+    """Return the message payload from known ``SupportsAgentRun`` call shapes."""
+    if messages is not None:
+        return messages
+    for field_name in ("messages", "input", "inputs"):
+        value = kwargs.get(field_name)
+        if value is not None:
+            return value
+    return messages
+
+
 def _message_role(message: Any) -> str | None:
     """Return a normalized role from dict-like or object-like messages."""
     role = _message_field(message, "role")
     if role is None:
         return None
-    return str(role).lower()
+    role_value = getattr(role, "value", role)
+    normalized = str(role_value).lower()
+    if normalized.startswith("messagerole."):
+        return normalized.rsplit(".", maxsplit=1)[-1]
+    return normalized
 
 
 def _message_field(message: Any, field_name: str) -> Any:

lib/tests/test_agents_hosted.py

@@ -2,10 +2,9 @@
 
 These tests cover the *translation logic* (free-form text -> handle dict ->
 AgentResponse) without requiring the optional
-``agent-framework-foundry-hosting`` package to be installed. End-to-end
-mount tests live under ``.tmp/probe_mount.py`` and the planned
-``inventory-health-check`` integration test once the SDK is available in
-the lib venv.
+``agent-framework-foundry-hosting`` package to be installed. When that SDK is
+present, the mounted ``/responses`` path is also exercised through FastAPI's
+``TestClient``.
 """
 
 from __future__ import annotations
@@ -19,6 +18,7 @@
     _extract_text_from_handle_result,
     _extract_user_text,
     _HostedAgentRunAdapter,
+    _resolve_run_messages,
 )
 
 
@@ -52,6 +52,12 @@ def __init__(
         self.input = input_value
 
 
+class _EnumRoleLike:
+    """Minimal enum-like role object matching SDK role.value behavior."""
+
+    value = "user"
+
+
 def test_extract_user_text_pulls_last_text_message() -> None:
     msgs = [
         Message(role="user", contents=[Content(type="text", text="earlier")]),
@@ -63,6 +69,21 @@ def test_extract_user_text_pulls_last_text_message() -> None:
     assert _extract_user_text(msgs) == "latest input text"
 
 
+def test_extract_user_text_reads_content_from_text_contract() -> None:
+    messages = [Message(role="user", contents=[Content.from_text("check health for SKU-1234")])]
+
+    assert _extract_user_text(messages) == "check health for SKU-1234"
+
+
+def test_extract_user_text_handles_enum_like_user_role() -> None:
+    message = _MessageLike(
+        role=_EnumRoleLike(),
+        contents=[Content.from_text("check health for SKU-1234")],
+    )
+
+    assert _extract_user_text([message]) == "check health for SKU-1234"
+
+
 @pytest.mark.parametrize(
     ("message", "expected"),
     [
@@ -121,6 +142,13 @@ def test_extract_user_text_handles_empty_inputs() -> None:
     assert _extract_user_text([]) == ""
 
 
+def test_resolve_run_messages_accepts_sdk_keyword_messages() -> None:
+    messages = [Message(role="user", contents=["kwarg"])]
+
+    assert _resolve_run_messages(None, {"messages": messages}) is messages
+    assert _resolve_run_messages(["positional"], {"messages": messages}) == ["positional"]
+
+
 def test_extract_text_from_handle_result_prefers_known_keys() -> None:
     assert _extract_text_from_handle_result({"text": "t-value"}) == "t-value"
     assert _extract_text_from_handle_result({"response": "r-value"}) == "r-value"
@@ -167,6 +195,23 @@ async def translator(text: str) -> dict[str, Any]:
     assert text == "hello-from-handle"
 
 
+@pytest.mark.asyncio
+async def test_hosted_run_adapter_uses_messages_from_kwargs() -> None:
+    agent = _RecordingAgent()
+
+    async def translator(text: str) -> dict[str, Any]:
+        return {"prompt": text}
+
+    adapter = _HostedAgentRunAdapter(agent, translator)
+    response = await adapter.run(messages=[Message(role="user", contents=["positional"])])
+    assert agent.last_request == {"prompt": "positional"}
+    assert response.messages
+
+    await adapter.run(input=[Message(role="user", contents=["kwarg-input"])])
+
+    assert agent.last_request == {"prompt": "kwarg-input"}
+
+
 @pytest.mark.asyncio
 async def test_hosted_run_adapter_streams_single_update() -> None:
     """``run(stream=True)`` must return an async iterator (NOT a coroutine).
@@ -301,3 +346,51 @@ def test_serve_hosted_honors_explicit_prefix_when_sdk_present() -> None:
     }
     paths.discard(None)
     assert "/v1/responses" in paths
+
+
+@pytest.mark.parametrize(
+    "body",
+    [
+        {"model": "inventory-health-check", "input": "check health for SKU-1234"},
+        {
+            "model": "inventory-health-check",
+            "input": [
+                {
+                    "type": "message",
+                    "role": "user",
+                    "content": "check health for SKU-1234",
+                }
+            ],
+        },
+        {
+            "model": "inventory-health-check",
+            "input": [
+                {
+                    "type": "message",
+                    "role": "user",
+                    "content": [{"type": "input_text", "text": "check health for SKU-1234"}],
+                }
+            ],
+        },
+    ],
+)
+def test_serve_hosted_responses_post_preserves_prompt_when_sdk_present(
+    body: dict[str, Any],
+) -> None:
+    pytest.importorskip("agent_framework_foundry_hosting")
+    from fastapi import FastAPI
+    from fastapi.testclient import TestClient
+
+    agent = _RecordingAgent()
+
+    async def translator(text: str) -> dict[str, Any]:
+        return {"prompt": text}
+
+    app = FastAPI()
+    agent.serve_hosted(app, request_translator=translator)
+    client = TestClient(app)
+
+    response = client.post("/responses", json=body)
+
+    assert response.status_code == 200
+    assert agent.last_request == {"prompt": "check health for SKU-1234"}