Fix ui-quality regression blocking PR validation

[Cataldir]

Problem statement

The ui-quality job in the test workflow is failing on PR #974 even though the PR does not modify apps/ui. Recent main runs for the same workflow have also failed, so this appears to be existing UI/test drift rather than a regression introduced by the continuous agent evaluation engine.

Current failing assertions from ui-quality include:

• tests/unit/pagesRender.test.tsx: TypeError: (0 , _useCart.useAddToCart) is not a function from ProductPageClient.tsx.
• tests/unit/pagesRender.test.tsx: expected Addresses tab is not found.
• tests/unit/pagesRender.test.tsx: expected campaign text is not found.
• tests/unit/apiClientMockAuth.test.ts: expected empty API base URL but received http://localhost:8000.
• tests/unit/productService.test.ts: expected /ecommerce-product-detail-enrichment/invoke call with { sku: "sku-1" }, but no call was made.

Acceptance criteria checklist

• apps/ui unit tests pass locally with the same command used by ui-quality.
• The ui-quality GitHub Actions job passes on a PR branch.
• Cart hook mocks expose useAddToCart consistently with the production hook contract.
• Page render tests are updated to match current UI copy and tab semantics, or the UI restores the expected accessible labels.
• API client tests explicitly control environment variables so default API URL behavior is deterministic.
• Product service tests verify the current enrichment invoke behavior or restore the missing call.

Risks and dependencies

• This blocks otherwise unrelated PRs from merging when branch protection requires ui-quality.
• The failure spans mocks, page render expectations, environment defaults, and product service behavior, so the fix should stay isolated to apps/ui test fixtures and affected UI service code.
• Coordinate with frontend/UI owners before changing user-facing copy or navigation semantics.

Evidence links

• PR Add continuous agent evaluation engine #974 check: https://github.com/Azure-Samples/holiday-peak-hub/actions/runs/25459963832/job/74699320489
• PR Add continuous agent evaluation engine #974 has no apps/ui file changes in origin/main...HEAD.
• Recent main test workflow runs have been failing since before this PR, including run 25171102700.

ADR impact

No ADR impact expected. This is a UI test/runtime regression fix and does not change deployment strategy, agent architecture, evaluation contracts, or service communication policy.

BPMN process

%%{init: {'theme':'base', 'themeVariables': {
  'primaryColor':'#FFB3BA',
  'primaryTextColor':'#000',
  'primaryBorderColor':'#FF8B94',
  'lineColor':'#BAE1FF',
  'secondaryColor':'#BAE1FF',
  'tertiaryColor':'#FFFFFF'
}}}%%
flowchart LR
  A[Analyze Current Code] --> B[Design Change]
  B --> C[Implement on Issue Branch]
  C --> D[Open PR]
  D --> E[Validation and Fixes]
  E --> F[Merge to Main]
  F --> G[Monitor Workflows]
  G --> H[Close Issue and Cleanup]

Loading

[Cataldir]

Closing as resolved. The regressions described here have been fixed by recent merges. Locally on main (15a2894):

• cd apps/ui && yarn test → 75 suites passed, 448 tests passed (no failures, no snapshots).
• The originally failing assertions in tests/unit/pagesRender.test.tsx, tests/unit/apiClientMockAuth.test.ts, and tests/unit/productService.test.ts all pass.
• CI evidence: PR chore(content,governance): owner+last_reviewed front-matter contract for /builders/enablement (#1052) #1085 ran the ui-quality job and it returned SUCCESS (https://github.com/Azure-Samples/holiday-peak-hub/actions/runs/25602290603/job/75158161522).

Residual act(...) warnings from ForwardRef(LoadableComponent) and recharts/ResponsiveContainer remain in stderr but do not fail any assertion. If a future regression reintroduces real failures, please open a fresh issue with the failing run.